Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19493

Stack trace shown when invalid URL entered

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      When creating or modifying a job, and selecting mercurial repository, a stacktrace is thrown, if no proper path is selected for the repository browser, especially also the trailing "/" is required

        Attachments

          Activity

          Hide
          planetmaker Mr planetmaker added a comment -

          Ah, when selecting a mercurial repository available through rhodecode. It works fine when accessing via hgweb.

          Show
          planetmaker Mr planetmaker added a comment - Ah, when selecting a mercurial repository available through rhodecode. It works fine when accessing via hgweb.
          Hide
          jglick Jesse Glick added a comment -

          Not sure if Jenkins really provides a way to better respond to invalid input (in your case, a host name which is not a URL); the invalid value cannot simply be saved without perhaps causing other errors later, and I do not know of a way for an individual form component handler to instruct the browser to return to the configuration screen. Certainly there ought to be form validation on the URL field in all the browser implementations, which would at least alert you before you clicked Save.

          Also RhodeCode/help-url.html is just copied from that for hgweb; it should be customized for RhodeCode users. Pull requests to correct such glitches would be welcome.

          Show
          jglick Jesse Glick added a comment - Not sure if Jenkins really provides a way to better respond to invalid input (in your case, a host name which is not a URL); the invalid value cannot simply be saved without perhaps causing other errors later, and I do not know of a way for an individual form component handler to instruct the browser to return to the configuration screen. Certainly there ought to be form validation on the URL field in all the browser implementations, which would at least alert you before you clicked Save . Also RhodeCode/help-url.html is just copied from that for hgweb; it should be customized for RhodeCode users. Pull requests to correct such glitches would be welcome.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Jesse Glick
          Path:
          src/main/java/hudson/plugins/mercurial/browser/BitBucket.java
          src/main/java/hudson/plugins/mercurial/browser/FishEye.java
          src/main/java/hudson/plugins/mercurial/browser/GoogleCode.java
          src/main/java/hudson/plugins/mercurial/browser/HgBrowser.java
          src/main/java/hudson/plugins/mercurial/browser/HgWeb.java
          src/main/java/hudson/plugins/mercurial/browser/KilnHG.java
          src/main/java/hudson/plugins/mercurial/browser/RhodeCode.java
          src/main/java/hudson/plugins/mercurial/browser/RhodeCodeLegacy.java
          src/test/java/hudson/plugins/mercurial/browser/HgBrowserTest.java
          http://jenkins-ci.org/commit/mercurial-plugin/776baa327f8f9dd78f8fcee1393d8b01734f11a6
          Log:
          [FIXED JENKINS-19493] Use form validation to alert users of invalid repository browser URLs before saving.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/plugins/mercurial/browser/BitBucket.java src/main/java/hudson/plugins/mercurial/browser/FishEye.java src/main/java/hudson/plugins/mercurial/browser/GoogleCode.java src/main/java/hudson/plugins/mercurial/browser/HgBrowser.java src/main/java/hudson/plugins/mercurial/browser/HgWeb.java src/main/java/hudson/plugins/mercurial/browser/KilnHG.java src/main/java/hudson/plugins/mercurial/browser/RhodeCode.java src/main/java/hudson/plugins/mercurial/browser/RhodeCodeLegacy.java src/test/java/hudson/plugins/mercurial/browser/HgBrowserTest.java http://jenkins-ci.org/commit/mercurial-plugin/776baa327f8f9dd78f8fcee1393d8b01734f11a6 Log: [FIXED JENKINS-19493] Use form validation to alert users of invalid repository browser URLs before saving.

            People

            • Assignee:
              jglick Jesse Glick
              Reporter:
              planetmaker Mr planetmaker
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: