Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19548

Missing change history for perforce change, changelog.xml not properly escaping content

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.523, RHEL 5.5, Perforce plugin 1.3.24, All changes plugin 1.3, changes since last success plugin 0.5
    • Similar Issues:

      Description

      For some perforce changes, the changes is empty when it shouldn't be. The changelog.xml contains the data, but it doesn't show up in Jenkins. Upon close inspection, trying to parse the xml results in

      XMLSyntaxError: Sequence ']]>' not allowed in content, line 1492, column 31

      Looking at the changelog.xml, the '<' reserved xml character is properly replaced with its entity reference &lt, but the '>' reserved xml character is not replaced with its entity reference &gt.

      The solution to this would be as simple as finding where the text is being placed in the xml (PerforceChangeLogParser.java?) and escaping all the xml reserved characters.

      The impact of this bug is that changes with reserved xml characters in the description can cause the changelog.xml to be syntactically incorrect, and Jenkins to falsely show no changes.

        Attachments

          Activity

            People

            • Assignee:
              rpetti Rob Petti
              Reporter:
              cmayeux Caleb Mayeux
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: