Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19649

changelog.xml is empty after upgrading to 1.3.25

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: perforce-plugin
    • Labels:
      None
    • Environment:
      Jenkins 1.532.2 LTS
    • Similar Issues:

      Description

      We upgraded to perforce plugin version 1.3.25. After doing so, Recent Changes in Jenkins is always empty. I checked the changelog.xml and it is basically empty, it contains:

      <changelog/>
      

      Polling seems to work fine as new builds are kicked off as changes are made, but the changes themselves are not availble to build. Reverting back to 1.3.24 fixes the issue.

        Attachments

        1. A.png
          A.png
          28 kB
        2. B.png
          B.png
          32 kB

          Activity

          Hide
          swolk swolk added a comment -

          Hi Rob, please see the attached screenshots. Screenshot A shows how the Use View MAsk option is not selected, so no matter how it is configured, it should not be used. Screenshot B shows how the View Mask settings are configured when I check the 'Use View Mask' option. The bug is that these View Mask settings are getting applied to the build even though the 'Use View Mask' parent option is disabled or false.

          Show
          swolk swolk added a comment - Hi Rob, please see the attached screenshots. Screenshot A shows how the Use View MAsk option is not selected, so no matter how it is configured, it should not be used. Screenshot B shows how the View Mask settings are configured when I check the 'Use View Mask' option. The bug is that these View Mask settings are getting applied to the build even though the 'Use View Mask' parent option is disabled or false.
          Hide
          swolk swolk added a comment -

          This change seems to have caused the issue:
          https://github.com/jenkinsci/perforce-plugin/commit/3de2bc83b884f68027f523375674163137ff2040#diff-a6a8e160fa20240410923ec7114cfacf

          -                    if (useViewMaskForSyncing && useViewMask) {
          
          +                    if (useViewMaskForChangeLog) {
          

          The extra useViewMask condition was removed which I believe is causing the issue.

          Show
          swolk swolk added a comment - This change seems to have caused the issue: https://github.com/jenkinsci/perforce-plugin/commit/3de2bc83b884f68027f523375674163137ff2040#diff-a6a8e160fa20240410923ec7114cfacf - if (useViewMaskForSyncing && useViewMask) { + if (useViewMaskForChangeLog) { The extra useViewMask condition was removed which I believe is causing the issue.
          Hide
          rpetti Rob Petti added a comment -

          Yes, I understand, and that's what I fixed in my last commit. I'm saying you need to disable "Use View Mask for Changelog" in order to get it working for your currently deployed version.

          I'll take a look at the change you linked, but it was working fine before some later configuration changes were made.

          Show
          rpetti Rob Petti added a comment - Yes, I understand, and that's what I fixed in my last commit. I'm saying you need to disable "Use View Mask for Changelog" in order to get it working for your currently deployed version. I'll take a look at the change you linked, but it was working fine before some later configuration changes were made.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Rob Petti
          Path:
          src/main/java/hudson/plugins/perforce/PerforceSCM.java
          src/test/java/hudson/plugins/perforce/PerforceSCMTest.java
          http://jenkins-ci.org/commit/perforce-plugin/ea1acb177d01e4e311df9df1f8fc069ed0efd1c1
          Log:
          [FIXED JENKINS-19649] viewmask config fix

          fixed condition for using the view mask for changelog
          fixed issue where view mask for changelog option could be enabled when loading config
          added test for optional configuration sections

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Rob Petti Path: src/main/java/hudson/plugins/perforce/PerforceSCM.java src/test/java/hudson/plugins/perforce/PerforceSCMTest.java http://jenkins-ci.org/commit/perforce-plugin/ea1acb177d01e4e311df9df1f8fc069ed0efd1c1 Log: [FIXED JENKINS-19649] viewmask config fix fixed condition for using the view mask for changelog fixed issue where view mask for changelog option could be enabled when loading config added test for optional configuration sections
          Hide
          swolk swolk added a comment -

          Rob, you rock! Thank you very much for addressing this. I went ahead on directly edited my jobs' config.xml files and set all ViewMask properties to false and reloaded Jenkins from them just in case. I'm on 1.3.27 now and everything is great.

          Show
          swolk swolk added a comment - Rob, you rock! Thank you very much for addressing this. I went ahead on directly edited my jobs' config.xml files and set all ViewMask properties to false and reloaded Jenkins from them just in case. I'm on 1.3.27 now and everything is great.

            People

            • Assignee:
              rpetti Rob Petti
              Reporter:
              swolk swolk
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: