Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19910

Support rebuilding projects using maven metadata plugin

    Details

    • Similar Issues:

      Attachments

        Activity

        Hide
        sylvain_mougenot Sylvain Mougenot added a comment -

        Using rebuild for a moment it worked fine until I add parameters from maven-metadata_plugin.
        Might be specific to that plugin

        Parameter everest_version_CLASSIFIER was "blank" in the first build.
        The build ran fine
        I wanted to relaunch with the same parameter using rebuild
        The new build failed with this stacktrace

        FATAL: Null value not allowed as an environment variable: everest_version_CLASSIFIER
        java.lang.IllegalArgumentException: Null value not allowed as an environment variable: everest_version_CLASSIFIER
        	at hudson.EnvVars.put(EnvVars.java:356)
        	at eu.markov.jenkins.plugin.mvnmeta.MavenMetadataParameterValue.buildEnvVars(MavenMetadataParameterValue.java:80)
        	at hudson.model.ParameterValue.buildEnvironment(ParameterValue.java:174)
        	at hudson.model.ParametersAction.buildEnvVars(ParametersAction.java:89)
        	at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:950)
        	at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1046)
        	at hudson.scm.SCM.checkout(SCM.java:485)
        	at hudson.model.AbstractProject.checkout(AbstractProject.java:1276)
        	at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607)
        	at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86)
        	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529)
        	at hudson.model.Run.execute(Run.java:1738)
        	at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43)
        	at hudson.model.ResourceController.execute(ResourceController.java:98)
        	at hudson.model.Executor.run(Executor.java:410)
        

        versions :

        component version
        jenkins 1.642.2
        maven-metadata_plugin 1.4.1
        rebuild-plugin 1.25
        Show
        sylvain_mougenot Sylvain Mougenot added a comment - Using rebuild for a moment it worked fine until I add parameters from maven-metadata_plugin. Might be specific to that plugin Parameter everest_version_CLASSIFIER was "blank" in the first build. The build ran fine I wanted to relaunch with the same parameter using rebuild The new build failed with this stacktrace FATAL: Null value not allowed as an environment variable: everest_version_CLASSIFIER java.lang.IllegalArgumentException: Null value not allowed as an environment variable: everest_version_CLASSIFIER at hudson.EnvVars.put(EnvVars.java:356) at eu.markov.jenkins.plugin.mvnmeta.MavenMetadataParameterValue.buildEnvVars(MavenMetadataParameterValue.java:80) at hudson.model.ParameterValue.buildEnvironment(ParameterValue.java:174) at hudson.model.ParametersAction.buildEnvVars(ParametersAction.java:89) at hudson.model.AbstractBuild.getEnvironment(AbstractBuild.java:950) at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1046) at hudson.scm.SCM.checkout(SCM.java:485) at hudson.model.AbstractProject.checkout(AbstractProject.java:1276) at hudson.model.AbstractBuild$AbstractBuildExecution.defaultCheckout(AbstractBuild.java:607) at jenkins.scm.SCMCheckoutStrategy.checkout(SCMCheckoutStrategy.java:86) at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:529) at hudson.model.Run.execute(Run.java:1738) at hudson.model.FreeStyleBuild.run(FreeStyleBuild.java:43) at hudson.model.ResourceController.execute(ResourceController.java:98) at hudson.model.Executor.run(Executor.java:410) versions : component version jenkins 1.642.2 maven-metadata_plugin 1.4.1 rebuild-plugin 1.25
        Hide
        mmchr Mads Mohr Christensen added a comment -

        It looks like the Maven Metadata Plugin is being maintained again and therefor it would be better to add support for rebuilding directly in that plugin instead of maintaining support in this plugin.

        I have created a PR for that: https://github.com/jenkinsci/maven-metadata-plugin/pull/12

        Show
        mmchr Mads Mohr Christensen added a comment - It looks like the Maven Metadata Plugin is being maintained again and therefor it would be better to add support for rebuilding directly in that plugin instead of maintaining support in this plugin. I have created a PR for that: https://github.com/jenkinsci/maven-metadata-plugin/pull/12
        Hide
        sylvain_mougenot Sylvain Mougenot added a comment -

        Nice of you to have done the PR
        I hope it will be merged soon
        Thank you

        Show
        sylvain_mougenot Sylvain Mougenot added a comment - Nice of you to have done the PR I hope it will be merged soon Thank you
        Hide
        scm_issue_link SCM/JIRA link daemon added a comment -

        Code changed in jenkins
        User: Marc Rohlfs
        Path:
        pom.xml
        src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataRebuildParameterProvider.java
        src/main/resources/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue/value.jelly
        http://jenkins-ci.org/commit/maven-metadata-plugin/7cda4a67b0636509536d26a38b41fb895f4e3e10
        Log:
        Merge pull request #12 from hrmohr/JENKINS-19910

        Added support for rebuilding

        Compare: https://github.com/jenkinsci/maven-metadata-plugin/compare/71ee75c47fae...7cda4a67b063

        Show
        scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marc Rohlfs Path: pom.xml src/main/lombok/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataRebuildParameterProvider.java src/main/resources/eu/markov/jenkins/plugin/mvnmeta/MavenMetadataParameterValue/value.jelly http://jenkins-ci.org/commit/maven-metadata-plugin/7cda4a67b0636509536d26a38b41fb895f4e3e10 Log: Merge pull request #12 from hrmohr/ JENKINS-19910 Added support for rebuilding Compare: https://github.com/jenkinsci/maven-metadata-plugin/compare/71ee75c47fae...7cda4a67b063
        Hide
        marcrohlfs Marc Rohlfs added a comment -

        Merged and released with maven-metadata-plugin-1.5.0.

        Show
        marcrohlfs Marc Rohlfs added a comment - Merged and released with maven-metadata-plugin-1.5.0 .

          People

          • Assignee:
            mmchr Mads Mohr Christensen
            Reporter:
            mmchr Mads Mohr Christensen
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: