Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-19947

Missing base directory in ZIP from .../artifact/dir/subdir/*zip*/subdir.zip

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      1.509.x would create a subdir.zip with a root entry subdir/. Development builds omit this top directory.

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment - - edited

            Jesse: Thanks for the hint!

            For reference, /path/to/dir/**/*zip*/foo.zip downloads a file named foo.zip with the contents of /path/to/dir (i.e. no top-level directory named dir in the zip file). /path/to/dir/*/*zip*/foo.zip downloads all the files in the directory dir, without sub-directories.

            To conveniently download these, enter the pattern ** or * into the box in the path bar, see a preview of what you're going to get, and only then click the download link.

            Show
            danielbeck Daniel Beck added a comment - - edited Jesse: Thanks for the hint! For reference, /path/to/dir/**/*zip*/foo.zip downloads a file named foo.zip with the contents of /path/to/dir (i.e. no top-level directory named dir in the zip file). /path/to/dir/*/*zip*/foo.zip downloads all the files in the directory dir , without sub-directories. To conveniently download these, enter the pattern ** or * into the box in the path bar, see a preview of what you're going to get, and only then click the download link.
            Hide
            jglick Jesse Glick added a comment -

            Thought it was something like that. So then the issue boils down to providing a more discoverable UI for this feature, or picking a better default behavior, etc.

            Show
            jglick Jesse Glick added a comment - Thought it was something like that. So then the issue boils down to providing a more discoverable UI for this feature, or picking a better default behavior, etc.
            Hide
            eyeamvic Victor Baca added a comment -

            This issue may have caused JENKINS-19752 to become an issue again. I am unable to validate that this issue is resolved due to the now corrupt ZIP file.

            Show
            eyeamvic Victor Baca added a comment - This issue may have caused JENKINS-19752 to become an issue again. I am unable to validate that this issue is resolved due to the now corrupt ZIP file.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/FilePath.java
            core/src/main/java/hudson/model/DirectoryBrowserSupport.java
            core/src/main/java/hudson/util/DirScanner.java
            test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java
            http://jenkins-ci.org/commit/jenkins/3695e614ed51c344bcc7deafaee44b11f7d1151d
            Log:
            [FIXED JENKINS-19947] Restore historical undocumented behavior of a top-level entry in a ZIP.
            Noting that various DirScanner implementations handle this inconsistently.

            (cherry picked from commit 793b6826e567e20a256a6d4166031e75a185ef7a)

            Conflicts:
            changelog.html

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/FilePath.java core/src/main/java/hudson/model/DirectoryBrowserSupport.java core/src/main/java/hudson/util/DirScanner.java test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java http://jenkins-ci.org/commit/jenkins/3695e614ed51c344bcc7deafaee44b11f7d1151d Log: [FIXED JENKINS-19947] Restore historical undocumented behavior of a top-level entry in a ZIP. Noting that various DirScanner implementations handle this inconsistently. (cherry picked from commit 793b6826e567e20a256a6d4166031e75a185ef7a) Conflicts: changelog.html
            Hide
            danielbeck Daniel Beck added a comment -

            Next LTS will be based on 1.554, which contains the original fix, so no backporting required.

            Show
            danielbeck Daniel Beck added a comment - Next LTS will be based on 1.554, which contains the original fix, so no backporting required.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: