Details

    • Type: Patch
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: tasks-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Attachments

      1. checkstyle_plugin.patch
        6 kB
      2. utf-8.patch
        2 kB
      3. utf-8.patch
        11 kB

        Issue Links

          Activity

          Hide
          unr303 unr303 added a comment -

          We use netbeans that uses ant to build projects: build.xml includes
          build-impl.xml that reads projects.properties and there are
          source.encoding=UTF-8 or source.encoding=windows-1251.
          Software consists of multiple projects (modules, libraries, core, etc).
          Structure of workspace after all checkouts is done is like so:

          core/corelib1 (project with utf-8 sources)
          core/corelib2 (project with utf-8 sources)
          core/kernel (legacy project with cp1251 sources)
          product/module1 (legacy project with cp1251 sources)
          product/module2 (project with utf-8 sources)
          product/build.xml (this simply refers to build.xml in all other projects to
          build everything)

          Each project have all files in one encoding only but different projects are in
          different encoding.

          As i can see trying to detect encoding from individual project settings would be
          very hard. And there are other IDE's and handwritten build.xml's that use
          different scheme. Simple path pattern to encoding would be simpliest but still
          working solution. Flexibility can be added with settings for default encoding
          and path patterns where encoding differs (so one have not to specify path
          pattern/encoding for every project in workspace). Or somethig like that.

          Show
          unr303 unr303 added a comment - We use netbeans that uses ant to build projects: build.xml includes build-impl.xml that reads projects.properties and there are source.encoding=UTF-8 or source.encoding=windows-1251. Software consists of multiple projects (modules, libraries, core, etc). Structure of workspace after all checkouts is done is like so: core/corelib1 (project with utf-8 sources) core/corelib2 (project with utf-8 sources) core/kernel (legacy project with cp1251 sources) product/module1 (legacy project with cp1251 sources) product/module2 (project with utf-8 sources) product/build.xml (this simply refers to build.xml in all other projects to build everything) Each project have all files in one encoding only but different projects are in different encoding. As i can see trying to detect encoding from individual project settings would be very hard. And there are other IDE's and handwritten build.xml's that use different scheme. Simple path pattern to encoding would be simpliest but still working solution. Flexibility can be added with settings for default encoding and path patterns where encoding differs (so one have not to specify path pattern/encoding for every project in workspace). Or somethig like that.
          Hide
          drulli Ulli Hafner added a comment -

          I added a defaultEncoding configuration option to the plug-ins checkstyle, pmd,
          findbugs, warnings and tasks.

          This option should be used by the source display and the various scanners. Could
          someone please verify this patch?

          Show
          drulli Ulli Hafner added a comment - I added a defaultEncoding configuration option to the plug-ins checkstyle, pmd, findbugs, warnings and tasks. This option should be used by the source display and the various scanners. Could someone please verify this patch?
          Hide
          sogabe sogabe added a comment -

          OS: Windows XP encoding Windows-31J
          source encoding: UTF-8
          AP server: winstone

          I tested checkstyle and task plugin with setting default encoding "UTF-8".
          But characters are garbled.

          Maybe winstone returns response with 'charset="ISO-8859-1"' not UTF-8.
          So you need the following snippet in jelly files.

          attached checkstyle_plugin.patch works for me.

          Show
          sogabe sogabe added a comment - OS: Windows XP encoding Windows-31J source encoding: UTF-8 AP server: winstone I tested checkstyle and task plugin with setting default encoding "UTF-8". But characters are garbled. Maybe winstone returns response with 'charset="ISO-8859-1"' not UTF-8. So you need the following snippet in jelly files. attached checkstyle_plugin.patch works for me.
          Hide
          sogabe sogabe added a comment -

          Created an attachment (id=493)
          patch for checkstyle plugin

          Show
          sogabe sogabe added a comment - Created an attachment (id=493) patch for checkstyle plugin
          Hide
          drulli Ulli Hafner added a comment -

          Thanks, I applied your patch to the other plug-ins, too. Additionally, I added
          the same header for the source code viewer jelly file. I hope that that works
          now in most cases.

          This patch will be available in the upcoming releases of my plug-ins. I'll close
          this issue, please reopen or create a new issue if something is not yet working.
          For the per file configuration, please open another feature request...

          Show
          drulli Ulli Hafner added a comment - Thanks, I applied your patch to the other plug-ins, too. Additionally, I added the same header for the source code viewer jelly file. I hope that that works now in most cases. This patch will be available in the upcoming releases of my plug-ins. I'll close this issue, please reopen or create a new issue if something is not yet working. For the per file configuration, please open another feature request...

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              bozaro Artem V. Navrotskiy
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: