Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20006

Use an actual AllView

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      For whatever reason, the default view of a new folder is set to a ListView matching all jobs. It would be more appropriate to use an actual AllView, like Jenkins root does; the user can always add other views if they need them.

      The ListView upgrade for an old existing folder (prior to folders being a ViewGroup) also seems to be unreliable; does not even log reflection failures if setting the regex fails.

      On a related note, currently a newly created folder shows in its "All" view a hint to use configure to add some existing jobs (and as of JENKINS-9330 also a hint to use newJob to create a new job). This makes no sense since there are no jobs in the folder yet. (Would be nice to have an extension point so that cloudbees-folders-plus could add a link to use "Move" from an existing job to physically move it into this folder.)

      Not possible when using a ListView since we can only override noJob.jelly for a custom view type. AllView/noJob.jelly is not much better in this case.

      Better would be to define a custom View type for the default view of a folder, either AllView or a subclass.

      For compatibility, if old metadata actually defined nontrivial columns and/or filters we would perhaps want to create an additional "Custom" ListView.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/a65a5028ded0654ad6f57950978838461a446767
            Log:
            [FIXED JENKINS-20235 JENKINS-20006] Configurable default view

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly http://jenkins-ci.org/commit/cloudbees-folder-plugin/a65a5028ded0654ad6f57950978838461a446767 Log: [FIXED JENKINS-20235 JENKINS-20006] Configurable default view
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/4aa06dc7e312a988cb1f9fd0f144be235d8e7018
            Log:
            Merge pull request #5 from daniel-beck/JENKINS-20235-20006

            [FIXED JENKINS-20235 JENKINS-20006] Configurable default view

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ac59f5238b08...4aa06dc7e312

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly http://jenkins-ci.org/commit/cloudbees-folder-plugin/4aa06dc7e312a988cb1f9fd0f144be235d8e7018 Log: Merge pull request #5 from daniel-beck/ JENKINS-20235 -20006 [FIXED JENKINS-20235 JENKINS-20006] Configurable default view Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/ac59f5238b08...4aa06dc7e312
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/08d327b3648641942ae89e23ba7f4db562f864a0
            Log:
            [FIXED JENKINS-20235 JENKINS-20006] Configurable default view

            Conflicts:
            src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly http://jenkins-ci.org/commit/cloudbees-folder-plugin/08d327b3648641942ae89e23ba7f4db562f864a0 Log: [FIXED JENKINS-20235 JENKINS-20006] Configurable default view Conflicts: src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java
            src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly
            http://jenkins-ci.org/commit/cloudbees-folder-plugin/9cbac2d026e315f41b7b4b2e51ca6d73b5a0092f
            Log:
            Merge pull request #7 from daniel-beck/stable

            [FIXED JENKINS-20523 JENKINS-20235 JENKINS-20006] for current LTS

            Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/4e62463c4411...9cbac2d026e3

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/com/cloudbees/hudson/plugins/folder/Folder.java src/main/resources/com/cloudbees/hudson/plugins/folder/Folder/configure.jelly http://jenkins-ci.org/commit/cloudbees-folder-plugin/9cbac2d026e315f41b7b4b2e51ca6d73b5a0092f Log: Merge pull request #7 from daniel-beck/stable [FIXED JENKINS-20523 JENKINS-20235 JENKINS-20006] for current LTS Compare: https://github.com/jenkinsci/cloudbees-folder-plugin/compare/4e62463c4411...9cbac2d026e3

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                jglick Jesse Glick
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: