Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20344

SVN_REVISION is not exported if server url end by / with further @HEAD suffix

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: subversion-plugin
    • Labels:
      None
    • Environment:
      subversion-1.50
    • Similar Issues:

      Description

      Server URL in config:

      • $PATH_TO_SCM/@HEAD

      Debug info (SubversionSCM.java:613):

      • Key in the "revisions" container: $PATH_TO_SCM
      • Value to be got in revisions.get() $PATH_TO_SCM/

      The issue is slash in the end.

        Attachments

          Issue Links

            Activity

            Show
            oleg_nenashev Oleg Nenashev added a comment - PR: https://github.com/jenkinsci/subversion-plugin/pull/54
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            src/main/java/hudson/scm/subversion/SvnHelper.java
            src/test/java/hudson/scm/SvnHelperTest.java
            http://jenkins-ci.org/commit/subversion-plugin/f74ea686fcb68aab0b3ff9730f4754cb0af02d27
            Log:
            [FIXED JENKINS-20344] - SVN_REVISION is not exported if server url end by / with further @HEAD suffix
            SvnHelper function also truncates ending slashes => hash search works correctly. Also added some tests...

            Resolves https://issues.jenkins-ci.org/browse/JENKINS-20344

            Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: src/main/java/hudson/scm/subversion/SvnHelper.java src/test/java/hudson/scm/SvnHelperTest.java http://jenkins-ci.org/commit/subversion-plugin/f74ea686fcb68aab0b3ff9730f4754cb0af02d27 Log: [FIXED JENKINS-20344] - SVN_REVISION is not exported if server url end by / with further @HEAD suffix SvnHelper function also truncates ending slashes => hash search works correctly. Also added some tests... Resolves https://issues.jenkins-ci.org/browse/JENKINS-20344 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christoph Kutzinski
            Path:
            src/main/java/hudson/scm/subversion/SvnHelper.java
            src/test/java/hudson/scm/SvnHelperTest.java
            http://jenkins-ci.org/commit/subversion-plugin/3e941d8dc920ab26cb1fdc2eef05f906a95f46ad
            Log:
            Merge pull request #54 from synopsys-arc-oss/jenkins_20344_fix

            [FIXED JENKINS-20344] - SVN_REVISION is not exported if server url ends ...

            Compare: https://github.com/jenkinsci/subversion-plugin/compare/a486adfb5c21...3e941d8dc920

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christoph Kutzinski Path: src/main/java/hudson/scm/subversion/SvnHelper.java src/test/java/hudson/scm/SvnHelperTest.java http://jenkins-ci.org/commit/subversion-plugin/3e941d8dc920ab26cb1fdc2eef05f906a95f46ad Log: Merge pull request #54 from synopsys-arc-oss/jenkins_20344_fix [FIXED JENKINS-20344] - SVN_REVISION is not exported if server url ends ... Compare: https://github.com/jenkinsci/subversion-plugin/compare/a486adfb5c21...3e941d8dc920

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: