Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-20791

ReleaseCause should extend UserIdCause

    Details

    • Similar Issues:

      Description

      hudson.model.Cause.UserCause is deprecated and class ReleaseCause should extend hudson.model.Cause.UserIdCause instead.
      Also, it should not override methods like getUserName() as it will cause issues for other plugins like build-user-vars (see JENKINS-20787)!

        Attachments

          Issue Links

            Activity

            Show
            ahammar Anders Hammar added a comment - Fix in https://github.com/jenkinsci/m2release-plugin/pull/14
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Anders Hammar
            Path:
            src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java
            http://jenkins-ci.org/commit/m2release-plugin/b1998ac16fc334d3ac8553c4630f722def49e333
            Log:
            JENKINS-20791 ReleaseCause should extend UserIdCause

            Signed-off-by: Anders Hammar <anders@hammar.net>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java http://jenkins-ci.org/commit/m2release-plugin/b1998ac16fc334d3ac8553c4630f722def49e333 Log: JENKINS-20791 ReleaseCause should extend UserIdCause Signed-off-by: Anders Hammar <anders@hammar.net>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: jtnord
            Path:
            src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java
            http://jenkins-ci.org/commit/m2release-plugin/6ecc03b4d2b6beae10642ae809b9266183e389f2
            Log:
            Merge pull request #14 from andham/JENKINS-20791

            JENKINS-20791 ReleaseCause should extend UserIdCause

            Compare: https://github.com/jenkinsci/m2release-plugin/compare/531f00df3c13...6ecc03b4d2b6

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: jtnord Path: src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java http://jenkins-ci.org/commit/m2release-plugin/6ecc03b4d2b6beae10642ae809b9266183e389f2 Log: Merge pull request #14 from andham/ JENKINS-20791 JENKINS-20791 ReleaseCause should extend UserIdCause Compare: https://github.com/jenkinsci/m2release-plugin/compare/531f00df3c13...6ecc03b4d2b6

              People

              • Assignee:
                ahammar Anders Hammar
                Reporter:
                ahammar Anders Hammar
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: