Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21045

maven 2/3 projects cannot store emailaddress

    Details

    • Similar Issues:

      Description

      After upgrade from mailer 1.5 to 1.6/1.7 it is no longer possible to edit email address for notification.
      Reproduceable by:

      • select project
      • edit configuration
      • add email address
      • edit configuration (again) --> emailaddress is gone

      See also https://issues.jenkins-ci.org/browse/JENKINS-20954

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/main/java/org/jenkinsci/test/acceptance/Matchers.java
            src/main/java/org/jenkinsci/test/acceptance/utils/mail/MailService.java
            src/test/java/plugins/MavenPluginTest.java
            http://jenkins-ci.org/commit/acceptance-test-harness/a4878c700d0fab5db68c33b93701f0658a1c54f6
            Log:
            Reproduce JENKINS-20209 and JENKINS-21045

            Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/f6d1423b7335...a4878c700d0f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/org/jenkinsci/test/acceptance/Matchers.java src/main/java/org/jenkinsci/test/acceptance/utils/mail/MailService.java src/test/java/plugins/MavenPluginTest.java http://jenkins-ci.org/commit/acceptance-test-harness/a4878c700d0fab5db68c33b93701f0658a1c54f6 Log: Reproduce JENKINS-20209 and JENKINS-21045 Compare: https://github.com/jenkinsci/acceptance-test-harness/compare/f6d1423b7335...a4878c700d0f
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/maven/reporters/MavenMailer.java
            http://jenkins-ci.org/commit/maven-plugin/ba7d53bfb7c14a6c3ee36db1a778646838d914bb
            Log:
            JENKINS-21045 MavenMailerTest was still using non-data-bound constructor; safest to keep it for compatibility.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/reporters/MavenMailer.java http://jenkins-ci.org/commit/maven-plugin/ba7d53bfb7c14a6c3ee36db1a778646838d914bb Log: JENKINS-21045 MavenMailerTest was still using non-data-bound constructor; safest to keep it for compatibility.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            pom.xml
            src/main/java/hudson/maven/MavenModuleSet.java
            src/main/java/hudson/maven/reporters/MavenMailer.java
            src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly
            src/main/resources/hudson/maven/reporters/MavenMailer/config.jelly
            http://jenkins-ci.org/commit/maven-plugin/4cceffb99bed63d2fa1ae262702273cd0983ee02
            Log:
            [FIXED JENKINS-21045] Hacks used by MavenMailer to load config.jelly from plain Mailer broke in mailer 1.6.
            Fixing to use its own copy of the configuration page.
            Also simplifying handling of perModuleEmail (this should be part of MavenMailer, not MavenModuleSet);
            and generally normalizing and simplifying form databinding.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: pom.xml src/main/java/hudson/maven/MavenModuleSet.java src/main/java/hudson/maven/reporters/MavenMailer.java src/main/resources/hudson/maven/MavenModuleSet/configure-entries.jelly src/main/resources/hudson/maven/reporters/MavenMailer/config.jelly http://jenkins-ci.org/commit/maven-plugin/4cceffb99bed63d2fa1ae262702273cd0983ee02 Log: [FIXED JENKINS-21045] Hacks used by MavenMailer to load config.jelly from plain Mailer broke in mailer 1.6. Fixing to use its own copy of the configuration page. Also simplifying handling of perModuleEmail (this should be part of MavenMailer, not MavenModuleSet); and generally normalizing and simplifying form databinding.
            Hide
            jglick Jesse Glick added a comment - - edited

            Bundled plugins can be upgraded. https://wiki.jenkins-ci.org/display/JENKINS/Pinned+Plugins

            But the 2.1 version of the Maven plugin requires Jenkins 1.538 or later. It cannot be run in LTS. (Or perhaps it could, but there might be various severe errors.) https://github.com/jenkinsci/maven-plugin/commit/e01eb60574c45b6c16091bfd91a05aa36071df68

            Show
            jglick Jesse Glick added a comment - - edited Bundled plugins can be upgraded. https://wiki.jenkins-ci.org/display/JENKINS/Pinned+Plugins But the 2.1 version of the Maven plugin requires Jenkins 1.538 or later. It cannot be run in LTS. (Or perhaps it could, but there might be various severe errors.) https://github.com/jenkinsci/maven-plugin/commit/e01eb60574c45b6c16091bfd91a05aa36071df68
            Hide
            ovaris Olli Varis added a comment -

            I'm sorry but how can you update Maven Integration plugin to 2.1 when it's bundled with Jenkins? We are using latest (LTS) Jenkins 1.532.1?

            Show
            ovaris Olli Varis added a comment - I'm sorry but how can you update Maven Integration plugin to 2.1 when it's bundled with Jenkins? We are using latest (LTS) Jenkins 1.532.1?
            Hide
            jomu78 Joern Muehlencord added a comment -

            Hi Jesse,
            I can confirm after updating mailer to 1.8 and maven integration to 2.1 its working fine. Thanks for the quick fix.

            Show
            jomu78 Joern Muehlencord added a comment - Hi Jesse, I can confirm after updating mailer to 1.8 and maven integration to 2.1 its working fine. Thanks for the quick fix.
            Hide
            jglick Jesse Glick added a comment -

            Was fixed in 2.1. (JIRA was apparently down so the issue link daemon did not note this.)

            Show
            jglick Jesse Glick added a comment - Was fixed in 2.1. (JIRA was apparently down so the issue link daemon did not note this.)
            Hide
            jglick Jesse Glick added a comment -

            After JENKINS-20226, the hacks the Maven plugin was using to embed a configuration page from the Mailer plugin broke.

            Show
            jglick Jesse Glick added a comment - After JENKINS-20226 , the hacks the Maven plugin was using to embed a configuration page from the Mailer plugin broke.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jomu78 Joern Muehlencord
              • Votes:
                3 Vote for this issue
                Watchers:
                7 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: