Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21060

Improve help text of "Number of successful release builds to keep"

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: m2release-plugin
    • Labels:
      None
    • Environment:
      Jenkins LTS 1.509.4, m2release 0.13-SNAPSHOT, Oracle JDK 1.7.0_25
    • Similar Issues:

      Description

      The "Number of successful release builds to keep" configuration does seem to work. I've configured it to "1", but the no release build is kept.
      To reproduce:
      1. Configure "Number of successful release builds to keep" to "1"
      2. Do a release build
      3. Do Snapshot builds until the release build is the last build
      4. Do yet another Snapshot build and you'll see the release build getting disposed

        Attachments

          Activity

          Hide
          ahammar Anders Hammar added a comment -

          Seems as I switched the order of 1) and 2) when doing my tests, which doesn't work. The configuration of "Number of successful release builds to keep" isn't applied until a release build is done. So if I re-configure and then only do Snapshot builds the new configuration will not be used.
          The help text should be improved with this info. I'll fix this and issue a pull request.

          Show
          ahammar Anders Hammar added a comment - Seems as I switched the order of 1) and 2) when doing my tests, which doesn't work. The configuration of "Number of successful release builds to keep" isn't applied until a release build is done. So if I re-configure and then only do Snapshot builds the new configuration will not be used. The help text should be improved with this info. I'll fix this and issue a pull request.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Anders Hammar
          Path:
          src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html
          http://jenkins-ci.org/commit/m2release-plugin/9fee394c9b4da38aa83872467dc7699f2538728d
          Log:
          [FIXED JENKINS-21060] Improve help text of "Number of successful release builds to keep"

          Signed-off-by: Anders Hammar <anders@hammar.net>

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html http://jenkins-ci.org/commit/m2release-plugin/9fee394c9b4da38aa83872467dc7699f2538728d Log: [FIXED JENKINS-21060] Improve help text of "Number of successful release builds to keep" Signed-off-by: Anders Hammar <anders@hammar.net>
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: jtnord
          Path:
          src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html
          http://jenkins-ci.org/commit/m2release-plugin/9f8cd64fda3b7b2baf2f8ebc2b30daa669bcbaa9
          Log:
          Merge pull request #18 from andham/JENKINS-21060

          [FIXED JENKINS-21060] Improve help text of "Number of successful release...

          Compare: https://github.com/jenkinsci/m2release-plugin/compare/e70a17d791e6...9f8cd64fda3b

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: jtnord Path: src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html http://jenkins-ci.org/commit/m2release-plugin/9f8cd64fda3b7b2baf2f8ebc2b30daa669bcbaa9 Log: Merge pull request #18 from andham/ JENKINS-21060 [FIXED JENKINS-21060] Improve help text of "Number of successful release... Compare: https://github.com/jenkinsci/m2release-plugin/compare/e70a17d791e6...9f8cd64fda3b
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Anders Hammar
          Path:
          pom.xml
          src/main/java/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper/config.jelly
          src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html
          src/main/webapp/help-projectConfig-selectAppendHudsonUsername.html
          http://jenkins-ci.org/commit/m2release-plugin/35d201a67b2e32850b68b75621aeb488cfe4c9df
          Log:
          Merge remote-tracking branch 'upstream/master' into JENKINS-21063

          • upstream/master:
            ReleasesCauses are now userIdCause - so update RSS appropriatly.
            [maven-release-plugin] prepare for next development iteration
            [maven-release-plugin] prepare release m2release-0.13.0
            Fixed a few UI text items in the project configuration dialog to align with text items in release dialog.
            [FIXED JENKINS-20983] Improve help text for "Preselect append Jenkins username" option
            [FIXED JENKINS-21060] Improve help text of "Number of successful release builds to keep"
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Anders Hammar Path: pom.xml src/main/java/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBuildWrapper/config.jelly src/main/webapp/help-projectConfig-numberOfReleaseBuildsToKeep.html src/main/webapp/help-projectConfig-selectAppendHudsonUsername.html http://jenkins-ci.org/commit/m2release-plugin/35d201a67b2e32850b68b75621aeb488cfe4c9df Log: Merge remote-tracking branch 'upstream/master' into JENKINS-21063 upstream/master: ReleasesCauses are now userIdCause - so update RSS appropriatly. [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release m2release-0.13.0 Fixed a few UI text items in the project configuration dialog to align with text items in release dialog. [FIXED JENKINS-20983] Improve help text for "Preselect append Jenkins username" option [FIXED JENKINS-21060] Improve help text of "Number of successful release builds to keep"

            People

            • Assignee:
              ahammar Anders Hammar
              Reporter:
              ahammar Anders Hammar
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: