Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21088

Normalize line endings in git repo

    Details

    • Similar Issues:

      Description

      It seems as there are files in the git repo with CRLF line endings, which causes changes by non-Windows users to show up as the entire file has changed (as the line ending will be converted to LF. This will also happen for Windows users with recommended git settings (core.autocrlf=true).
      This is not good as it makes it difficult to see what was actually changed.

      The git repo needs to be normalized on line endings (LF). Also, a .gitattributes file should be added to prevent the same problem from happen again.

      See:
      https://help.github.com/articles/dealing-with-line-endings
      http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/

        Attachments

          Activity

          Hide
          ahammar Anders Hammar added a comment -

          Pull request sent.

          Show
          ahammar Anders Hammar added a comment - Pull request sent.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: jtnord
          Path:
          .gitattributes
          pom.xml
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java
          src/main/java/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet.java
          src/main/java/org/jvnet/hudson/plugins/m2release/nexus/Stage.java
          src/main/java/org/jvnet/hudson/plugins/m2release/nexus/StageAction.java
          src/main/java/org/jvnet/hudson/plugins/m2release/nexus/StageClient.java
          src/main/java/org/jvnet/hudson/plugins/m2release/nexus/StageException.java
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseAction/failed.jelly
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseAction/index.jelly
          src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly
          src/main/resources/org/jvnet/hudson/plugins/m2release/Messages.properties
          src/main/resources/org/jvnet/hudson/plugins/m2release/ReleaseCause/description.jelly
          src/main/resources/org/jvnet/hudson/plugins/m2release/ReleaseCause/description.properties
          src/main/resources/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet/config.jelly
          src/main/resources/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet/main.jelly
          src/main/resources/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet/portlet.jelly
          src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseArgumentInterceptorActionTest.java
          src/test/java/org/jvnet/hudson/plugins/m2release/nexus/StageClientTest.java
          src/test/java/org/jvnet/hudson/plugins/m2release/nexus/StageTest.java
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/activity__closed_failed.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/activity__closed_ok.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/profile_repositories.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/repository__transitioned.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/repository__transitioning.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/status__bad_perms.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/status__ok_perms.xml
          src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageTest/service/local/staging/profiles
          test/pom.xml
          test/src/main/java/test/Hello.java
          http://jenkins-ci.org/commit/m2release-plugin/e70a17d791e6b76d5e565f1887c903ecd3872569
          Log:
          Merge pull request #16 from andham/JENKINS-21088

          [FIXED JENKINS-21088] Normalize line endings in git repo

          Compare: https://github.com/jenkinsci/m2release-plugin/compare/f3426cc37b57...e70a17d791e6

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: jtnord Path: .gitattributes pom.xml src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseAction.java src/main/java/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction.java src/main/java/org/jvnet/hudson/plugins/m2release/ReleaseCause.java src/main/java/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet.java src/main/java/org/jvnet/hudson/plugins/m2release/nexus/Stage.java src/main/java/org/jvnet/hudson/plugins/m2release/nexus/StageAction.java src/main/java/org/jvnet/hudson/plugins/m2release/nexus/StageClient.java src/main/java/org/jvnet/hudson/plugins/m2release/nexus/StageException.java src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseAction/failed.jelly src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseAction/index.jelly src/main/resources/org/jvnet/hudson/plugins/m2release/M2ReleaseBadgeAction/badge.jelly src/main/resources/org/jvnet/hudson/plugins/m2release/Messages.properties src/main/resources/org/jvnet/hudson/plugins/m2release/ReleaseCause/description.jelly src/main/resources/org/jvnet/hudson/plugins/m2release/ReleaseCause/description.properties src/main/resources/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet/config.jelly src/main/resources/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet/main.jelly src/main/resources/org/jvnet/hudson/plugins/m2release/dashboard/RecentReleasesPortlet/portlet.jelly src/test/java/org/jvnet/hudson/plugins/m2release/M2ReleaseArgumentInterceptorActionTest.java src/test/java/org/jvnet/hudson/plugins/m2release/nexus/StageClientTest.java src/test/java/org/jvnet/hudson/plugins/m2release/nexus/StageTest.java src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/activity__closed_failed.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/activity__closed_ok.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/profile_repositories.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/repository__transitioned.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/repository__transitioning.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/status__bad_perms.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageClientTest/status__ok_perms.xml src/test/resources/org/jvnet/hudson/plugins/m2release/nexus/stageTest/service/local/staging/profiles test/pom.xml test/src/main/java/test/Hello.java http://jenkins-ci.org/commit/m2release-plugin/e70a17d791e6b76d5e565f1887c903ecd3872569 Log: Merge pull request #16 from andham/ JENKINS-21088 [FIXED JENKINS-21088] Normalize line endings in git repo Compare: https://github.com/jenkinsci/m2release-plugin/compare/f3426cc37b57...e70a17d791e6

            People

            • Assignee:
              ahammar Anders Hammar
              Reporter:
              ahammar Anders Hammar
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: