Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21248

Add shallow update init for submodule

    Details

    • Similar Issues:

      Description

      Recent versions of cgit support shallow clone support in submodule. Like this
      git submodule update --init --depth 1

      But it doesn't support this new feature in current version of git-client-plugin.

        Attachments

          Activity

          Hide
          sverhoef Stefan Verhoeff added a comment -

          Thanks for the details Mark Waite. I'm happy to help with testing this useful feature.

          How can I check what version of Git is used by the checkout() command? I assume it would be the same I get when I run git --version just above it. Is there a different Git binary used? Is the checkout actually happening on the Master and the sh() command on the agent? Is JGit involved? I'm confused here.

          As per your acceptance test, does this point at an issue with the version parsing or not? I've checked the code around where the warning Git client older than 1.8.4 doesn't support shallow submodule updates. This flag is ignored. is raised, the shallow clone arguments are never actually added to the Git command because of the failed version check, so I'm not getting errors from Git on this.

          Show
          sverhoef Stefan Verhoeff added a comment - Thanks for the details Mark Waite . I'm happy to help with testing this useful feature. How can I check what version of Git is used by the  checkout() command? I assume it would be the same I get when I run git --version just above it. Is there a different Git binary used? Is the checkout actually happening on the Master and the  sh() command on the agent? Is JGit involved? I'm confused here. As per your acceptance test, does this point at an issue with the version parsing or not? I've checked the code around where the warning Git client older than 1.8.4 doesn't support shallow submodule updates. This flag is ignored. is raised, the shallow clone arguments are never actually added to the Git command because of the failed version check, so I'm not getting errors from Git on this.
          Hide
          markewaite Mark Waite added a comment -

          My acceptance test is strong evidence that there is not an issue with version parsing .

          Check the jenkins system configuration of the git tool and the agent configuration of the git tool

          Show
          markewaite Mark Waite added a comment - My acceptance test is strong evidence that there is not an issue with version parsing . Check the jenkins system configuration of the git tool and the agent configuration of the git tool
          Hide
          gegles Guillaume Egles added a comment -

          When will this be released?

          Show
          gegles Guillaume Egles added a comment - When will this be released?
          Hide
          markewaite Mark Waite added a comment -

          It is available in git plugiin 4.0.0-beta12 and git client plugin 3.0.0 beta12 now. Please test it in your use case. I intend to release git plugin 4.0.0 and git client plugin 3.0.0 in about 1 week and would sincerely appreciate additional beta testers confirming that the new plugin features are working as expected.

          Release Notes

          Download

          Show
          markewaite Mark Waite added a comment - It is available in git plugiin 4.0.0-beta12 and git client plugin 3.0.0 beta12 now. Please test it in your use case. I intend to release git plugin 4.0.0 and git client plugin 3.0.0 in about 1 week and would sincerely appreciate additional beta testers confirming that the new plugin features are working as expected. Release Notes Git client plugin 3.0.0-beta12 Git plugin 4.0.0-beta12 Download Git client plugin 3.0.0-beta12 Git plugin 4.0.0-beta12
          Hide
          markewaite Mark Waite added a comment -

          Released with git client plugin 3.0.0 and git plugin 4.0.0 on Nov 2, 2019.

          Show
          markewaite Mark Waite added a comment - Released with git client plugin 3.0.0 and git plugin 4.0.0 on Nov 2, 2019.

            People

            • Assignee:
              Unassigned
              Reporter:
              monaka Masaki Muranaka
            • Votes:
              22 Vote for this issue
              Watchers:
              25 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: