Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21357

Node monitoring action: Use the specific computer's sidepanel instead of Jenkins default page

    Details

    • Similar Issues:

      Description

      Just a follow up to the issue discovered by Daniel Beck
      https://github.com/jenkinsci/monitoring-plugin/pull/1

      Jenkins side panel don't significantly affect the actions's usability, so there is no need in urgent release.

        Attachments

          Activity

          Hide
          danielbeck Daniel Beck added a comment -

          Note that Computer's sidepanel.jelly might require a change as well since it just uses relative URLs instead of ${rootURL}/${it.url} as it probably should.

          Show
          danielbeck Daniel Beck added a comment - Note that Computer's sidepanel.jelly might require a change as well since it just uses relative URLs instead of ${rootURL}/${it.url } as it probably should.
          Hide
          danielbeck Daniel Beck added a comment -

          Label as well.

          Show
          danielbeck Daniel Beck added a comment - Label as well.
          Hide
          oleg_nenashev Oleg Nenashev added a comment - - edited

          Yep, a straightforward replacement will work for AbstractProject's sidepanel only.

          Seems it may be resolved by temporarily changing the current page, but I'm not sure that such hack is applicable due to the minor impact of the issue.

          Show
          oleg_nenashev Oleg Nenashev added a comment - - edited Yep, a straightforward replacement will work for AbstractProject's sidepanel only. Seems it may be resolved by temporarily changing the current page, but I'm not sure that such hack is applicable due to the minor impact of the issue.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: evernat
          Path:
          src/main/resources/org/jvnet/hudson/plugins/monitoring/NodeMonitoringAction/index.jelly
          http://jenkins-ci.org/commit/monitoring-plugin/f0a0a81291fed17ef3077d67100461a22eef08b2
          Log:
          [FIXED JENKINS-21357] Node monitoring action: Use the specific computer's sidepanel instead of Jenkins default page

          Computer's sidepanel.jelly still need to use ${rootURL}/${it.url}
          instead of relative URLs

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: evernat Path: src/main/resources/org/jvnet/hudson/plugins/monitoring/NodeMonitoringAction/index.jelly http://jenkins-ci.org/commit/monitoring-plugin/f0a0a81291fed17ef3077d67100461a22eef08b2 Log: [FIXED JENKINS-21357] Node monitoring action: Use the specific computer's sidepanel instead of Jenkins default page Computer's sidepanel.jelly still need to use ${rootURL}/${it.url} instead of relative URLs
          Hide
          evernat evernat added a comment -

          JENKINS-23963 is just created for Computer's sidepanel.jelly

          Show
          evernat evernat added a comment - JENKINS-23963 is just created for Computer's sidepanel.jelly

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: