Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21411

Add option to easily review changes sequentially (Add Next & Previous links)

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      In case of viewing 2 sequential changes (which is the default behavior) it would be great to have Next & Previous links to allow you to move to the next/previous pair of changes (see attached suggestions).

      Currently in order to do this, once you are already in the comparison view, you are required to use 4 clicks:

      • go back (1 click)
      • select the next 2 version (2 clicks)
      • compare them (1 click)
        This is very useful when searching for specific changes by replacing all the above in a single click.

        Attachments

          Activity

          Hide
          boev Yordan Boev added a comment -

          What happens if the 2 changes being compared are not sequential(one after the other?) and/or when we want to change only one of the files shown? I think next pair of changes is not clearly defined here. It would be better if both File A and File B had Prev and Next so that we could navigate better by changing only one of the 2 xml files being compared. It would require 2 clicks to show the "next pair of changes", but it's more flexible this way.

          Show
          boev Yordan Boev added a comment - What happens if the 2 changes being compared are not sequential(one after the other?) and/or when we want to change only one of the files shown? I think next pair of changes is not clearly defined here. It would be better if both File A and File B had Prev and Next so that we could navigate better by changing only one of the 2 xml files being compared. It would require 2 clicks to show the "next pair of changes", but it's more flexible this way.
          Hide
          esinsag Sagi Sinai-Glazer added a comment -

          Yordan - I agree that in case the changes are not consecutive then the question does arise. This is why I stated that in case they are sequential (which is easy to determine programmatically) then we can add the Next/Previous pair comparison. I also agree with your proposition in case they are not one after the other - a next/prev button for each would we a good addition.

          Show
          esinsag Sagi Sinai-Glazer added a comment - Yordan - I agree that in case the changes are not consecutive then the question does arise. This is why I stated that in case they are sequential (which is easy to determine programmatically) then we can add the Next/Previous pair comparison. I also agree with your proposition in case they are not one after the other - a next/prev button for each would we a good addition.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stefan Brausch
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
          src/main/resources/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction/showDiffFiles.jelly
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/869921de373cf916d84f7f03741b357965cdbc39
          Log:
          JENKINS-21411 Shift (Prev/Next) for diff results

          Both sides goes to the next or previous entry (shift)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Brausch Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java src/main/resources/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction/showDiffFiles.jelly http://jenkins-ci.org/commit/jobConfigHistory-plugin/869921de373cf916d84f7f03741b357965cdbc39 Log: JENKINS-21411 Shift (Prev/Next) for diff results Both sides goes to the next or previous entry (shift)
          Hide
          stefanbrausch Stefan Brausch added a comment -

          Sorry @Yordan I don't remember that you started with this issue already.
          At the moment is a shift for job diffs only. I will add this feature to slaves and system diffs soon.
          Maybe we can add buttons for expand and shrink the selection also?

          Show
          stefanbrausch Stefan Brausch added a comment - Sorry @Yordan I don't remember that you started with this issue already. At the moment is a shift for job diffs only. I will add this feature to slaves and system diffs soon. Maybe we can add buttons for expand and shrink the selection also?
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stefan Brausch
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction.java
          src/main/resources/hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction/showDiffFiles.jelly
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/ba5576fd9ea3c2d1afc2cc9a197b581f81b14acb
          Log:
          JENKINS-21411 Shift (Prev/Next) for diff results for slaves

          Compare: https://github.com/jenkinsci/jobConfigHistory-plugin/compare/05c453c24e2c...ba5576fd9ea3

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Brausch Path: src/main/java/hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction.java src/main/resources/hudson/plugins/jobConfigHistory/ComputerConfigHistoryAction/showDiffFiles.jelly http://jenkins-ci.org/commit/jobConfigHistory-plugin/ba5576fd9ea3c2d1afc2cc9a197b581f81b14acb Log: JENKINS-21411 Shift (Prev/Next) for diff results for slaves Compare: https://github.com/jenkinsci/jobConfigHistory-plugin/compare/05c453c24e2c...ba5576fd9ea3
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stefan Brausch
          Path:
          src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java
          src/main/resources/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction/showDiffFiles.jelly
          http://jenkins-ci.org/commit/jobConfigHistory-plugin/370a6aec397597117be68b480c4bd59ae910df91
          Log:
          JENKINS-21411 Shrinking and expanding range for diff view (job view only)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stefan Brausch Path: src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction.java src/main/resources/hudson/plugins/jobConfigHistory/JobConfigHistoryProjectAction/showDiffFiles.jelly http://jenkins-ci.org/commit/jobConfigHistory-plugin/370a6aec397597117be68b480c4bd59ae910df91 Log: JENKINS-21411 Shrinking and expanding range for diff view (job view only)
          Hide
          stefanbrausch Stefan Brausch added a comment -

          Feature released in version 2.6

          Show
          stefanbrausch Stefan Brausch added a comment - Feature released in version 2.6

            People

            • Assignee:
              stefanbrausch Stefan Brausch
              Reporter:
              esinsag Sagi Sinai-Glazer
            • Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: