Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-21887

Check git version before attempting to use credential.helper

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      GitHub's help page says:

      You need git 1.7.10 or newer to use the credential helper

      It would be nice if git-client could detect an unsupported version of Git and throw an error instead of making it look like something else is broken. (the call to git config succeeded, but the git fetch after it failed)

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Mark Waite
            Path:
            src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
            http://jenkins-ci.org/commit/git-client-plugin/7667ecd49e9da9db3e9385826bad56ee851adacb
            Log:
            Warn if git version does not support credentials

            JENKINS-21887 The git credentials support was not added until git 1.7.9.

            This commit will only provide a warning in the log file, but will
            still attempt to execute the credentials operations.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mark Waite Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/7667ecd49e9da9db3e9385826bad56ee851adacb Log: Warn if git version does not support credentials JENKINS-21887 The git credentials support was not added until git 1.7.9. This commit will only provide a warning in the log file, but will still attempt to execute the credentials operations.
            Hide
            markewaite Mark Waite added a comment - - edited

            Rather than throw an error and risk incompatibility or broken builds if the check is wrong, the code has been extended to write a warning to the log file if the Jenkins version is too old for credentials support. It will still attempt the credentials related operations, but there will be a warning in the console log which may help the user understand why the credentials are not working.

            The change will be visible in git-client-plugin 1.8.1.

            Show
            markewaite Mark Waite added a comment - - edited Rather than throw an error and risk incompatibility or broken builds if the check is wrong, the code has been extended to write a warning to the log file if the Jenkins version is too old for credentials support. It will still attempt the credentials related operations, but there will be a warning in the console log which may help the user understand why the credentials are not working. The change will be visible in git-client-plugin 1.8.1.

              People

              • Assignee:
                ndeloof Nicolas De Loof
                Reporter:
                oli_at_jsi Olivier Dagenais
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: