Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22073

ProjectAction should render graph, optimize build.xml size

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: cppcheck-plugin
    • Labels:
      None
    • Environment:
      All
    • Similar Issues:

      Description

      The trend graph is part of project/job page and should be created in CppcheckProjectAction instead of in CppcheckBuildAction. Every build.xml file contains full plugin configuration including all information for rendering of trend graph, this is not needed.

            <cppcheckConfig>
              <pattern>cppcheck.xml</pattern>
              <ignoreBlankFiles>false</ignoreBlankFiles>
              <allowNoReport>false</allowNoReport>
              <configSeverityEvaluation>
                <threshold>42</threshold>
                <newThreshold>42</newThreshold>
                <failureThreshold>42</failureThreshold>
                <newFailureThreshold>42</newFailureThreshold>
                <healthy>42</healthy>
                <unHealthy>42</unHealthy>
                <severityError>true</severityError>
                <severityWarning>true</severityWarning>
                <severityStyle>true</severityStyle>
                <severityPerformance>true</severityPerformance>
                <severityInformation>true</severityInformation>
                <severityNoCategory>true</severityNoCategory>
                <severityPortability>true</severityPortability>
              </configSeverityEvaluation>
              <configGraph>
                <xSize>42</xSize>
                <ySize>42</ySize>
                <displayAllErrors>true</displayAllErrors>
                <displayErrorSeverity>true</displayErrorSeverity>
                <displayWarningSeverity>true</displayWarningSeverity>
                <displayStyleSeverity>true</displayStyleSeverity>
                <displayPerformanceSeverity>true</displayPerformanceSeverity>
                <displayInformationSeverity>true</displayInformationSeverity>
                <displayNoCategorySeverity>true</displayNoCategorySeverity>
                <displayPortabilitySeverity>true</displayPortabilitySeverity>
              </configGraph>
            </cppcheckConfig>
      

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckBuildAction.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/util/AbstractCppcheckBuildAction.java
          src/main/java/com/thalesgroup/hudson/plugins/cppcheck/util/CppcheckBuildHealthEvaluator.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckBuildAction.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckProjectAction.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java
          src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java
          src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfig.java
          src/main/java/org/jenkinsci/plugins/cppcheck/util/AbstractCppcheckProjectAction.java
          src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckBuildHealthEvaluator.java
          src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckBuildResultEvaluator.java
          src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckMetricUtil.java
          src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/util/Messages.properties
          src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties
          http://jenkins-ci.org/commit/cppcheck-plugin/87b16349d8b2c64c9105254cbd1e38cef000d5d5
          Log:
          JENKINS-22073 ProjectAction should render graph, optimize build.xml size

          • Issue: The trend graph is part of project/job page and should be created in CppcheckProjectAction instead of in CppcheckBuildAction.
          • Issue: Every build.xml file contains full plugin configuration, this is not needed.
          • Creating of the graph moved from CppcheckBuildAction to proper CppcheckProjectAction.
          • CppcheckBuildAction now stores no configuration which results in smaller build.xml.
          • Various methods updated to receive only CppcheckConfigSeverityEvaluation in their parameters.
          • Weather column in the jobs table (mouse over tool tip) updated to contain only a constant label with a percentage, use of a deprecated API removed. It isn't neccessary to dynamically show a configuration here. This allows to replace whole <configSeverityEvaluation> part of build.xml by one integer.
          • Several @SuppressWarnings("unused") that are causing compiler warnings removed.
          • Code updated to be better readable.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/com/thalesgroup/hudson/plugins/cppcheck/CppcheckBuildAction.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/util/AbstractCppcheckBuildAction.java src/main/java/com/thalesgroup/hudson/plugins/cppcheck/util/CppcheckBuildHealthEvaluator.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckBuildAction.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckProjectAction.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckPublisher.java src/main/java/org/jenkinsci/plugins/cppcheck/CppcheckResult.java src/main/java/org/jenkinsci/plugins/cppcheck/config/CppcheckConfig.java src/main/java/org/jenkinsci/plugins/cppcheck/util/AbstractCppcheckProjectAction.java src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckBuildHealthEvaluator.java src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckBuildResultEvaluator.java src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckMetricUtil.java src/main/resources/com/thalesgroup/hudson/plugins/cppcheck/util/Messages.properties src/main/resources/org/jenkinsci/plugins/cppcheck/Messages.properties http://jenkins-ci.org/commit/cppcheck-plugin/87b16349d8b2c64c9105254cbd1e38cef000d5d5 Log: JENKINS-22073 ProjectAction should render graph, optimize build.xml size Issue: The trend graph is part of project/job page and should be created in CppcheckProjectAction instead of in CppcheckBuildAction. Issue: Every build.xml file contains full plugin configuration, this is not needed. Creating of the graph moved from CppcheckBuildAction to proper CppcheckProjectAction. CppcheckBuildAction now stores no configuration which results in smaller build.xml. Various methods updated to receive only CppcheckConfigSeverityEvaluation in their parameters. Weather column in the jobs table (mouse over tool tip) updated to contain only a constant label with a percentage, use of a deprecated API removed. It isn't neccessary to dynamically show a configuration here. This allows to replace whole <configSeverityEvaluation> part of build.xml by one integer. Several @SuppressWarnings("unused") that are causing compiler warnings removed. Code updated to be better readable.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michal Turek
          Path:
          src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckBuildResultEvaluator.java
          http://jenkins-ci.org/commit/cppcheck-plugin/229cd1b28a9d795dadffdbc5f9066694e6f48226
          Log:
          JENKINS-22073 ProjectAction should render graph, optimize build.xml size

          • Forgotten unsaved file commited.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michal Turek Path: src/main/java/org/jenkinsci/plugins/cppcheck/util/CppcheckBuildResultEvaluator.java http://jenkins-ci.org/commit/cppcheck-plugin/229cd1b28a9d795dadffdbc5f9066694e6f48226 Log: JENKINS-22073 ProjectAction should render graph, optimize build.xml size Forgotten unsaved file commited.
          Hide
          mixalturek Michal Turek added a comment -

          Fixed, will be released in version 1.15.

          Show
          mixalturek Michal Turek added a comment - Fixed, will be released in version 1.15.

            People

            • Assignee:
              mixalturek Michal Turek
              Reporter:
              mixalturek Michal Turek
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: