Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22126

envinject overrides build parameters with node environment

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: envinject-plugin
    • Labels:
      None
    • Environment:
      Environment Injector Plugin 1.89
    • Similar Issues:

      Description

      on slave system env I have FOO set. This is also the name for a build parameter. I expect FOO to be set during build to parameter value I pass to build, but with envinject installed (even when not enabled on my job) build parameter is overiden with node environment.

      This wasn't the case in 1.76 and previous, seems this has been introduced by https://github.com/jenkinsci/envinject-plugin/commit/ed245ce8c7b4562159291a3599d6638e65301155. Anyway I don't understand JENKINS-14437 use-case, I doesn't make sense to me to override build parameters (why would you define a parameter then ?).

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De Loof
          Path:
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectJobProperty/config.jelly
          http://jenkins-ci.org/commit/envinject-plugin/f99197cea54c828365736984c6c4e184774e6b12
          Log:
          JENKINS-22126 override build parameters only when explicitly requested on configuration

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De Loof Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectJobProperty/config.jelly http://jenkins-ci.org/commit/envinject-plugin/f99197cea54c828365736984c6c4e184774e6b12 Log: JENKINS-22126 override build parameters only when explicitly requested on configuration
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Gregory Boissinot
          Path:
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java
          src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectJobProperty/config.jelly
          http://jenkins-ci.org/commit/envinject-plugin/91cac44dc42ad63b463d6103e6a36b12e9bfb4f0
          Log:
          Merge pull request #26 from ndeloof/JENKINS-22126

          JENKINS-22126 override build parameters only when explicitly requested

          Compare: https://github.com/jenkinsci/envinject-plugin/compare/65851e8783af...91cac44dc42a

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectJobProperty.java src/main/resources/org/jenkinsci/plugins/envinject/EnvInjectJobProperty/config.jelly http://jenkins-ci.org/commit/envinject-plugin/91cac44dc42ad63b463d6103e6a36b12e9bfb4f0 Log: Merge pull request #26 from ndeloof/ JENKINS-22126 JENKINS-22126 override build parameters only when explicitly requested Compare: https://github.com/jenkinsci/envinject-plugin/compare/65851e8783af...91cac44dc42a

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              ndeloof Nicolas De Loof
            • Votes:
              3 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: