Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22165

Confusing label for the list of regex that include and exclude files

    Details

    • Type: Patch
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: findbugs-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      The labels "Bugs to include" and "Bugs to ignore" seem to refer to bugs that can be included or ignored.

      However, what they really specify is a list of regex that include or exclude files from being processed by findbugs, not bugs.

      Here's my proposed patch:

      diff --git a/plugin/src/main/resources/findbugs/filter.jelly b/plugin/src/main/resources/findbugs/filter.jelly
      — a/plugin/src/main/resources/findbugs/filter.jelly
      +++ b/plugin/src/main/resources/findbugs/filter.jelly
      @@ -6,10 +6,10 @@
      <j:jelly xmlns:j="jelly:core" xmlns:st="jelly:stapler" xmlns:d="jelly:define"
      xmlns:l="/lib/layout" xmlns:t="/lib/hudson" xmlns:f="/lib/form">

      • <f:entry title="$ {%Bugs to include}

        " field="includePattern" description="$

        {%description.includePattern}">
        + <f:entry title="${%Files to include}" field="includePattern" description="${%description.includePattern}

        ">
        <f:textbox />
        </f:entry>

      • <f:entry title="$ {%Bugs to ignore}

        " field="excludePattern" description="$

        {%description.excludePattern}">
        + <f:entry title="${%Files to exclude}" field="excludePattern" description="${%description.excludePattern}

        ">
        <f:textbox />
        </f:entry>

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/tasks/TasksTabDetail/tasks-details_de.properties
          http://jenkins-ci.org/commit/tasks-plugin/98d165cbf71304bae093b8513767669bdae36be5
          Log:
          [FIXED JENKINS-22165] Improved labels.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/tasks/TasksTabDetail/tasks-details_de.properties http://jenkins-ci.org/commit/tasks-plugin/98d165cbf71304bae093b8513767669bdae36be5 Log: [FIXED JENKINS-22165] Improved labels.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/analysis/collector/dashboard/WarningsTablePortlet/WarningsPerJobDescriptor/local-config_de.properties
          http://jenkins-ci.org/commit/analysis-collector-plugin/38d5eee32ea5ad02c4112330fbaefa464ec3abc7
          Log:
          [FIXED JENKINS-22165] Improved labels.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/analysis/collector/dashboard/WarningsTablePortlet/WarningsPerJobDescriptor/local-config_de.properties http://jenkins-ci.org/commit/analysis-collector-plugin/38d5eee32ea5ad02c4112330fbaefa464ec3abc7 Log: [FIXED JENKINS-22165] Improved labels.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          parent.iml
          plugin/src/main/resources/findbugs/filter.jelly
          plugin/src/main/resources/findbugs/filter.properties
          plugin/src/main/resources/hudson/plugins/findbugs/FindBugsResult/index_de.properties
          pom.xml
          http://jenkins-ci.org/commit/findbugs-plugin/22ff1ab5162ff03daf1a7755ebe8d7328cc57983
          Log:
          [FIXED JENKINS-22165] Improved labels.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: parent.iml plugin/src/main/resources/findbugs/filter.jelly plugin/src/main/resources/findbugs/filter.properties plugin/src/main/resources/hudson/plugins/findbugs/FindBugsResult/index_de.properties pom.xml http://jenkins-ci.org/commit/findbugs-plugin/22ff1ab5162ff03daf1a7755ebe8d7328cc57983 Log: [FIXED JENKINS-22165] Improved labels.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          src/main/resources/hudson/plugins/dry/DryTabDetail/dry-warnings_de.properties
          http://jenkins-ci.org/commit/dry-plugin/ed6b7afe589b374edd12f601ce0159f58f9ef56c
          Log:
          [FIXED JENKINS-22165] Improved labels.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: src/main/resources/hudson/plugins/dry/DryTabDetail/dry-warnings_de.properties http://jenkins-ci.org/commit/dry-plugin/ed6b7afe589b374edd12f601ce0159f58f9ef56c Log: [FIXED JENKINS-22165] Improved labels.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Ulli Hafner
          Path:
          .idea/compiler.xml
          .idea/encodings.xml
          analysis-core
          http://jenkins-ci.org/commit/analysis-suite-plugin/e8c8f4b79e0962fd6d805b84bc9c1d9912e2c0f9
          Log:
          [FIXED JENKINS-22165] Improved labels.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ulli Hafner Path: .idea/compiler.xml .idea/encodings.xml analysis-core http://jenkins-ci.org/commit/analysis-suite-plugin/e8c8f4b79e0962fd6d805b84bc9c1d9912e2c0f9 Log: [FIXED JENKINS-22165] Improved labels.

            People

            • Assignee:
              drulli Ulli Hafner
              Reporter:
              elifarley Elifarley
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: