Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22397

A Trigger should be able to be a DependencyDeclarer

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      It is common for a Publisher to be a DependencyDeclarer: an upstream project which kicks off a downstream project can thus add an edge to the dependency graph. But the converse should also be true: if a downstream project has a (non-pseudo) Trigger which involves an upstream project, it should be able to record that as an edge, too.

        Attachments

          Issue Links

            Activity

            Show
            jglick Jesse Glick added a comment - See https://github.com/jenkinsci/jenkins/pull/1168 and https://github.com/jenkinsci/buildresult-trigger-plugin/pull/9 for its usage.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/matrix/MatrixProject.java
            core/src/main/java/hudson/model/AbstractProject.java
            core/src/main/java/hudson/model/Project.java
            core/src/main/java/jenkins/model/DependencyDeclarer.java
            http://jenkins-ci.org/commit/jenkins/efd2b990fbb14de2947dbd405cbfc3c4323d7216
            Log:
            [FIXED JENKINS-22397] Allow a Trigger to be a DependencyDeclarer.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/matrix/MatrixProject.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Project.java core/src/main/java/jenkins/model/DependencyDeclarer.java http://jenkins-ci.org/commit/jenkins/efd2b990fbb14de2947dbd405cbfc3c4323d7216 Log: [FIXED JENKINS-22397] Allow a Trigger to be a DependencyDeclarer.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            core/src/main/java/hudson/matrix/MatrixProject.java
            core/src/main/java/hudson/model/AbstractProject.java
            core/src/main/java/hudson/model/Project.java
            core/src/main/java/jenkins/model/DependencyDeclarer.java
            http://jenkins-ci.org/commit/jenkins/769bd8195049def65ab3ed84dd5a7046cb7b3a3a
            Log:
            Merge pull request #1168 from jglick/Trigger-DependencyDeclarer-JENKINS-22397

            JENKINS-22397 Allow a Trigger to be a DependencyDeclarer

            Compare: https://github.com/jenkinsci/jenkins/compare/f97b5b33b075...769bd8195049

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html core/src/main/java/hudson/matrix/MatrixProject.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Project.java core/src/main/java/jenkins/model/DependencyDeclarer.java http://jenkins-ci.org/commit/jenkins/769bd8195049def65ab3ed84dd5a7046cb7b3a3a Log: Merge pull request #1168 from jglick/Trigger-DependencyDeclarer- JENKINS-22397 JENKINS-22397 Allow a Trigger to be a DependencyDeclarer Compare: https://github.com/jenkinsci/jenkins/compare/f97b5b33b075...769bd8195049
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3266
            [FIXED JENKINS-22397] Allow a Trigger to be a DependencyDeclarer. (Revision efd2b990fbb14de2947dbd405cbfc3c4323d7216)

            Result = SUCCESS
            Jesse Glick : efd2b990fbb14de2947dbd405cbfc3c4323d7216
            Files :

            • core/src/main/java/jenkins/model/DependencyDeclarer.java
            • changelog.html
            • core/src/main/java/hudson/matrix/MatrixProject.java
            • core/src/main/java/hudson/model/AbstractProject.java
            • core/src/main/java/hudson/model/Project.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3266 [FIXED JENKINS-22397] Allow a Trigger to be a DependencyDeclarer. (Revision efd2b990fbb14de2947dbd405cbfc3c4323d7216) Result = SUCCESS Jesse Glick : efd2b990fbb14de2947dbd405cbfc3c4323d7216 Files : core/src/main/java/jenkins/model/DependencyDeclarer.java changelog.html core/src/main/java/hudson/matrix/MatrixProject.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Project.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java
            http://jenkins-ci.org/commit/buildresult-trigger-plugin/104cf3f22fe1af9a0f4c0dce07ab09ca4c71e19d
            Log:
            JENKINS-22397 Take advantage of core API (when merged) to show the upstream project in the dependency graph.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java http://jenkins-ci.org/commit/buildresult-trigger-plugin/104cf3f22fe1af9a0f4c0dce07ab09ca4c71e19d Log: JENKINS-22397 Take advantage of core API (when merged) to show the upstream project in the dependency graph.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Gregory Boissinot
            Path:
            src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java
            http://jenkins-ci.org/commit/buildresult-trigger-plugin/7d07d2e12168666b8d08c00fc7d76f15b24e0478
            Log:
            Merge pull request #9 from jglick/Trigger-DependencyDeclarer-JENKINS-22397

            JENKINS-22397 Show upstream project in dependency graph

            Compare: https://github.com/jenkinsci/buildresult-trigger-plugin/compare/cfca4f2cc9ff...7d07d2e12168

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Gregory Boissinot Path: src/main/java/org/jenkinsci/plugins/buildresulttrigger/BuildResultTrigger.java http://jenkins-ci.org/commit/buildresult-trigger-plugin/7d07d2e12168666b8d08c00fc7d76f15b24e0478 Log: Merge pull request #9 from jglick/Trigger-DependencyDeclarer- JENKINS-22397 JENKINS-22397 Show upstream project in dependency graph Compare: https://github.com/jenkinsci/buildresult-trigger-plugin/compare/cfca4f2cc9ff...7d07d2e12168
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/hudson/maven/MavenModuleSet.java
            http://jenkins-ci.org/commit/maven-plugin/9ac66ee95d401330f99e1c0fd1fecc35e4c61227
            Log:
            [FIXED JENKINS-23686] Fix of JENKINS-22397 not automatically available to overriders of buildDependencyGraph unless they were using 1.558+ and calling super.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/hudson/maven/MavenModuleSet.java http://jenkins-ci.org/commit/maven-plugin/9ac66ee95d401330f99e1c0fd1fecc35e4c61227 Log: [FIXED JENKINS-23686] Fix of JENKINS-22397 not automatically available to overriders of buildDependencyGraph unless they were using 1.558+ and calling super.

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: