Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22740

Launcher's afterDisconnect() method is called twice

    Details

    • Similar Issues:

      Description

      The call to r.getExecutor().getOwner().disconnect() in vSphereCloudSlave causes vSphereCloudLauncher's afterDisconnect() to be called twice, on separate threads. This means, for instance, that a VM configured to shutdown and revert after a disconnect will do so twice.

      This appears to be an issue with Jenkins itself.

      A temporary fix on my side is the use of an AtomicBoolean to prevent the afterDisconnect from executing its logic twice. Would this be considered an acceptable patch?

        Attachments

          Issue Links

            Activity

            Hide
            hrabbouh Hossam Rabbouh added a comment -

            Looked into it: calling r.getExecutor().getOwner().getChannel().close() instead of r.getExecutor().getOwner().disconnect() fixes this issue. It's a more "brutal" method, but it works.

            I can submit a pull request with this and some other changes tonight, to be reviewed.

            Show
            hrabbouh Hossam Rabbouh added a comment - Looked into it: calling r.getExecutor().getOwner().getChannel().close() instead of r.getExecutor().getOwner().disconnect() fixes this issue. It's a more "brutal" method, but it works. I can submit a pull request with this and some other changes tonight, to be reviewed.
            Hide
            hrabbouh Hossam Rabbouh added a comment -

            Pull request successfully merged; thanks to the team. Fix available in version 1.1.6.

            Show
            hrabbouh Hossam Rabbouh added a comment - Pull request successfully merged; thanks to the team. Fix available in version 1.1.6.

              People

              • Assignee:
                Unassigned
                Reporter:
                hrabbouh Hossam Rabbouh
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: