Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-22818

Jenkins on Linux can not restart after plugin update

    Details

    • Similar Issues:

      Description

      Jenkins can not restart after plugin update if jenkins' java is started with 'java' and without full path.

      It doesn't rexec itself with the following logs:
      Warnung: Failed to restart Jenkins
      java.io.IOException: Failed to exec 'java' Datei oder Verzeichnis nicht gefunden
      at hudson.lifecycle.UnixLifecycle.restart(UnixLifecycle.java:84)
      at jenkins.model.Jenkins$24.run(Jenkins.java:3337)

      It seems to be caused by this recent change:
      https://github.com/jenkinsci/jenkins/commit/547d4ed8d35de6be4b2788e4816019bb8cc94902#diff-1df54b5ad5f99455e21579688db5be50

      From a quick look I guess this could be fixed by using execvp instead of execv as below:

      • LIBC.execv(exe, new StringArray(args.toArray(new String[args.size()])));
        + LIBC.execvp(exe, new StringArray(args.toArray(new String[args.size()])));

      I understand that for those calling java as /usr/bin/java the execv approach should work, but without the full path it should still work IMHO.

      Thanks,
      Simon

        Attachments

          Activity

          Hide
          oleg_nenashev Oleg Nenashev added a comment -

          Increased the bug's priority.
          The issue has been introduced in 1.561, hence the LTS backporting is not required

          Show
          oleg_nenashev Oleg Nenashev added a comment - Increased the bug's priority. The issue has been introduced in 1.561, hence the LTS backporting is not required
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Yoann Dubreuil
          Path:
          core/src/main/java/hudson/lifecycle/UnixLifecycle.java
          core/src/main/java/hudson/util/jna/GNUCLibrary.java
          http://jenkins-ci.org/commit/jenkins/3ddd2b0c0876239316b5cfc6bca497821bd200b8
          Log:
          [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path

          The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character.
          Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Yoann Dubreuil Path: core/src/main/java/hudson/lifecycle/UnixLifecycle.java core/src/main/java/hudson/util/jna/GNUCLibrary.java http://jenkins-ci.org/commit/jenkins/3ddd2b0c0876239316b5cfc6bca497821bd200b8 Log: [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character. Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902
          Hide
          vjuranek vjuranek added a comment -

          Should be fixed by proposed patch (PR #1239)

          Show
          vjuranek vjuranek added a comment - Should be fixed by proposed patch (PR #1239)
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #3413
          [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path (Revision 3ddd2b0c0876239316b5cfc6bca497821bd200b8)

          Result = SUCCESS
          Vojtech Juranek : 3ddd2b0c0876239316b5cfc6bca497821bd200b8
          Files :

          • core/src/main/java/hudson/lifecycle/UnixLifecycle.java
          • core/src/main/java/hudson/util/jna/GNUCLibrary.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3413 [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path (Revision 3ddd2b0c0876239316b5cfc6bca497821bd200b8) Result = SUCCESS Vojtech Juranek : 3ddd2b0c0876239316b5cfc6bca497821bd200b8 Files : core/src/main/java/hudson/lifecycle/UnixLifecycle.java core/src/main/java/hudson/util/jna/GNUCLibrary.java
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Yoann Dubreuil
          Path:
          core/src/main/java/hudson/lifecycle/UnixLifecycle.java
          core/src/main/java/hudson/util/jna/GNUCLibrary.java
          http://jenkins-ci.org/commit/jenkins/c3ddea2a71d61eeed39012155a15297b0059874a
          Log:
          [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path

          The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character.
          Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902

          (cherry picked from commit 3ddd2b0c0876239316b5cfc6bca497821bd200b8)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Yoann Dubreuil Path: core/src/main/java/hudson/lifecycle/UnixLifecycle.java core/src/main/java/hudson/util/jna/GNUCLibrary.java http://jenkins-ci.org/commit/jenkins/c3ddea2a71d61eeed39012155a15297b0059874a Log: [FIX JENKINS-22818] fix jenkins restart on Linux after plugin update if the java executable running Jenkins is started without its full path The patch uses 'execvp' instead of 'execv' to lookup the java executable filename in the PATH if the specified filename does not contain a slash character. Regression introduced in 547d4ed8d35de6be4b2788e4816019bb8cc94902 (cherry picked from commit 3ddd2b0c0876239316b5cfc6bca497821bd200b8)

            People

            • Assignee:
              Unassigned
              Reporter:
              simix Simon Matter
            • Votes:
              1 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: