Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23017

git client plugin creates unlimited directories in /tmp/ for polling the scm

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: git-client-plugin
    • Labels:
      None
    • Environment:
      git client plugin 1.9.0, git plugin 2.2.1, jenkins 1.562
    • Similar Issues:

      Description

      For every polling cycle the git client creates a new directory for storing the credentials in /tmp/ but forgets to delete the directory itself after finishing the polling.

      This leads to reaching the system limit of maximum numbers of subdirectories after some time which will break the polling cycle.

      • This results in jenkins not starting builds on scm changes.
      • The normal build process is not affected.
      • This could affect some other functionality using the tmp directory and creating files there.

      This behaviour was introduced with JENKINS-22039.

        Attachments

          Activity

          Hide
          uhausbrand Uwe Hausbrand added a comment -

          I provided a fix for this issue with the pull request https://github.com/jenkinsci/git-client-plugin/pull/133.

          Show
          uhausbrand Uwe Hausbrand added a comment - I provided a fix for this issue with the pull request https://github.com/jenkinsci/git-client-plugin/pull/133 .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Uwe Hausbrand
          Path:
          src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
          http://jenkins-ci.org/commit/git-client-plugin/d771d97f1e126b1b01ea214ef245d2d5f432200e
          Log:
          [Fix JENKINS-23017] delete the tmp workdir also

          In order to not leave unlimited directories created by the polling cycle
          in the tmp directory which results in reaching the system limit for
          subdirectory numbers we should also delete the workdir itself and not ony its
          contents.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Uwe Hausbrand Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/d771d97f1e126b1b01ea214ef245d2d5f432200e Log: [Fix JENKINS-23017] delete the tmp workdir also In order to not leave unlimited directories created by the polling cycle in the tmp directory which results in reaching the system limit for subdirectory numbers we should also delete the workdir itself and not ony its contents.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nicolas De loof
          Path:
          src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java
          http://jenkins-ci.org/commit/git-client-plugin/a04dcd9d7396dee31ef73a94f5e23d5f334c7c47
          Log:
          Merge pull request #133 from uhausbrand/JENKINS-23017

          [Fix JENKINS-23017] delete the tmp workdir also

          Compare: https://github.com/jenkinsci/git-client-plugin/compare/6eddb7e7b0a8...a04dcd9d7396

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nicolas De loof Path: src/main/java/org/jenkinsci/plugins/gitclient/CliGitAPIImpl.java http://jenkins-ci.org/commit/git-client-plugin/a04dcd9d7396dee31ef73a94f5e23d5f334c7c47 Log: Merge pull request #133 from uhausbrand/ JENKINS-23017 [Fix JENKINS-23017] delete the tmp workdir also Compare: https://github.com/jenkinsci/git-client-plugin/compare/6eddb7e7b0a8...a04dcd9d7396
          Hide
          markewaite Mark Waite added a comment -

          Fixed in git-client-plugin 1.9.1

          Show
          markewaite Mark Waite added a comment - Fixed in git-client-plugin 1.9.1

            People

            • Assignee:
              ndeloof Nicolas De Loof
              Reporter:
              uhausbrand Uwe Hausbrand
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: