Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23134

Mixed separators fail for Linux paths

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Apparently a separator fix for latest version (2.11.1) broke how paths are built, and this leads to failed builds on Linux slaves.

      2.10:
      [android] Ensuring platform(s) are installed: [android-8, android-19]
      $ /home/jenkins/android-sdk-linux/tools/android list target

      2.11.1:
      [android] Ensuring platform(s) are installed: [android-8, android-19]
      $ /home/jenkins/android-sdk-linux\tools\android list target
      FATAL: Cannot run program "/home/jenkins/android-sdk-linux\tools\android": error=2, No such file or directory
      java.io.IOException: Cannot run program "/home/jenkins/android-sdk-linux\tools\android": error=2, No such file or directory

        Attachments

          Issue Links

            Activity

            Hide
            xfreebird Nicolae Ghimbovschi added a comment - - edited

            Also, adb -s emulator-5834 shell getprop dev.bootcomplete does not work on OSX.
            It works only with adb connect localhost:5834

            Show
            xfreebird Nicolae Ghimbovschi added a comment - - edited Also, adb -s emulator-5834 shell getprop dev.bootcomplete does not work on OSX. It works only with adb connect localhost:5834
            Hide
            orrc Christopher Orr added a comment -

            So I did a terrible job of reviewing the code that caused this bug, and a terrible job of fixing it so far.

            I've been working on some other fixes and will do a release soon. So I will merge and test this pull request which should fix this issue: https://github.com/jenkinsci/android-emulator-plugin/pull/44

            Show
            orrc Christopher Orr added a comment - So I did a terrible job of reviewing the code that caused this bug, and a terrible job of fixing it so far. I've been working on some other fixes and will do a release soon. So I will merge and test this pull request which should fix this issue: https://github.com/jenkinsci/android-emulator-plugin/pull/44
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Dave Brown
            Path:
            src/main/java/hudson/plugins/android_emulator/sdk/DefaultToolLocator.java
            src/main/java/hudson/plugins/android_emulator/sdk/PlatformToolLocator.java
            http://jenkins-ci.org/commit/android-emulator-plugin/28f76bb7acfd96a16a1eb5626b2527ad9b96856f
            Log:
            JENKINS-23134 Replace File.separator with "/".

            When using this plugin on a Windows master delegating to a Unix slave
            File.separator resolves to "
            " resulting in erroneous paths.

            Signed-off-by: Dave Brown <d.brown@bigdavedev.com>

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Dave Brown Path: src/main/java/hudson/plugins/android_emulator/sdk/DefaultToolLocator.java src/main/java/hudson/plugins/android_emulator/sdk/PlatformToolLocator.java http://jenkins-ci.org/commit/android-emulator-plugin/28f76bb7acfd96a16a1eb5626b2527ad9b96856f Log: JENKINS-23134 Replace File.separator with "/". When using this plugin on a Windows master delegating to a Unix slave File.separator resolves to " " resulting in erroneous paths. Signed-off-by: Dave Brown <d.brown@bigdavedev.com>
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Christopher Orr
            Path:
            src/main/java/hudson/plugins/android_emulator/sdk/DefaultToolLocator.java
            src/main/java/hudson/plugins/android_emulator/sdk/PlatformToolLocator.java
            http://jenkins-ci.org/commit/android-emulator-plugin/98d2a53130cb7165b80e08b2496822ec20bbda68
            Log:
            Merge pull request #44 from bigdavedev/master

            [FIXED JENKINS-23134] Replace File.separator with "/".

            Fixes inability to launch Android tools on Unix slaves from a Windows master.

            Compare: https://github.com/jenkinsci/android-emulator-plugin/compare/a0589ce14556...98d2a53130cb

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: src/main/java/hudson/plugins/android_emulator/sdk/DefaultToolLocator.java src/main/java/hudson/plugins/android_emulator/sdk/PlatformToolLocator.java http://jenkins-ci.org/commit/android-emulator-plugin/98d2a53130cb7165b80e08b2496822ec20bbda68 Log: Merge pull request #44 from bigdavedev/master [FIXED JENKINS-23134] Replace File.separator with "/". Fixes inability to launch Android tools on Unix slaves from a Windows master. Compare: https://github.com/jenkinsci/android-emulator-plugin/compare/a0589ce14556...98d2a53130cb
            Hide
            orrc Christopher Orr added a comment -

            Version 2.13 of the plugin has been released, which includes this fix.

            Show
            orrc Christopher Orr added a comment - Version 2.13 of the plugin has been released, which includes this fix.

              People

              • Assignee:
                orrc Christopher Orr
                Reporter:
                cowst Diego Costantini
              • Votes:
                8 Vote for this issue
                Watchers:
                11 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: