Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23306

Unstable jobs are shown with the same size as stable ones

    Details

    • Similar Issues:

      Description

      Seems like the Radiator plugin treats unstable & stable jobs as correct ones, and only failed ones as problematic.

      I really like the idea of displaying the failed one bigger than OK (when showing also stable, I mean), but I guess this would be even better to display unstable ones with a bigger size than stable ones.

      I'm attaching a screenshot to clarify.

      If you don't think this idea is stupid/useless, if you want we could even have a look at the code and propose a PR.

      Thanks for the feedback.

        Attachments

          Activity

          Hide
          batmat Baptiste Mathus added a comment - - edited

          Cf. https://github.com/jenkinsci/radiatorview-plugin/pull/13 I chose what I think is the simplest and still sensible path: the code still behaves the same when there's a job in failure. But if there's not, then unstable ones are then displayed bigger than successful ones.

          Show
          batmat Baptiste Mathus added a comment - - edited Cf. https://github.com/jenkinsci/radiatorview-plugin/pull/13 I chose what I think is the simplest and still sensible path: the code still behaves the same when there's a job in failure. But if there's not, then unstable ones are then displayed bigger than successful ones.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Baptiste Mathus
          Path:
          src/main/java/hudson/model/ProjectViewEntry.java
          http://jenkins-ci.org/commit/radiatorview-plugin/cafd297384a5cc6afb5b0497783d4ff91faf8505
          Log:
          If no failing jobs, consider unstable as failures.

          Fixes JENKINS-23306

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/hudson/model/ProjectViewEntry.java http://jenkins-ci.org/commit/radiatorview-plugin/cafd297384a5cc6afb5b0497783d4ff91faf8505 Log: If no failing jobs, consider unstable as failures. Fixes JENKINS-23306
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Baptiste Mathus
          Path:
          src/main/java/hudson/model/ProjectViewEntry.java
          http://jenkins-ci.org/commit/radiatorview-plugin/186f58de0c9308b645de8afd639b046515b1b958
          Log:
          Merge branch 'JENKINS-23306'

          Compare: https://github.com/jenkinsci/radiatorview-plugin/compare/56bad2b56319...186f58de0c93

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/hudson/model/ProjectViewEntry.java http://jenkins-ci.org/commit/radiatorview-plugin/186f58de0c9308b645de8afd639b046515b1b958 Log: Merge branch ' JENKINS-23306 ' Compare: https://github.com/jenkinsci/radiatorview-plugin/compare/56bad2b56319...186f58de0c93
          Hide
          batmat Baptiste Mathus added a comment -

          Fixed with 186f58de0c9308b645de8afd639b046515b1b958 merge.

          Show
          batmat Baptiste Mathus added a comment - Fixed with 186f58de0c9308b645de8afd639b046515b1b958 merge.

            People

            • Assignee:
              batmat Baptiste Mathus
              Reporter:
              batmat Baptiste Mathus
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: