Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23411

Parallel deletion of jobs from the ListView may lead to NPE errors

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      A report from Coverity:

      *** CID 1222626:  Dereference null return value  (NULL_RETURNS)
      /src/main/java/hudson/model/ListView.java: 334 in hudson.model.ListView.doRemoveJobFromView(java.lang.String)()
      328         @RequirePOST
      329         public HttpResponse doRemoveJobFromView(@QueryParameter String name) throws IOException, ServletException {
      330             checkPermission(View.CONFIGURE);
      331             if(name==null)
      332                 throw new Failure("Query parameter 'name' is required");
      333
      >>>     CID 1222626:  Dereference null return value  (NULL_RETURNS)
      >>>     Assigning: "item" = null return value from "resolveName".
      334             TopLevelItem item = resolveName(name);
      335             if (remove(item))
      336                 owner.save();
      337
      338             return HttpResponses.ok();
      339         }
      

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: kel
          Path:
          core/src/main/java/hudson/model/ListView.java
          test/src/test/java/hudson/model/ListViewTest.java
          http://jenkins-ci.org/commit/jenkins/fddffb4fbceb50e0c8801044319e84dc6f9b7e90
          Log:
          [Fix JENKINS-23411] Throws Failure if the item does not exist (#3007)

          • [Fix JENKINS-23411] Throws Failure if the item does not exist
          • [Fix JENKINS-23411] Adress wording in error message
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: kel Path: core/src/main/java/hudson/model/ListView.java test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/fddffb4fbceb50e0c8801044319e84dc6f9b7e90 Log: [Fix JENKINS-23411] Throws Failure if the item does not exist (#3007) [Fix JENKINS-23411] Throws Failure if the item does not exist [Fix JENKINS-23411] Adress wording in error message
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: liketic
          Path:
          test/src/test/java/hudson/model/ListViewTest.java
          http://jenkins-ci.org/commit/jenkins/0b56fb5354b483f5a0f0860f587f5f3cc1b8d939
          Log:
          [Fix JENKINS-23411] Fix testing failure introduced in PR-3007

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: liketic Path: test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/0b56fb5354b483f5a0f0860f587f5f3cc1b8d939 Log: [Fix JENKINS-23411] Fix testing failure introduced in PR-3007
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          test/src/test/java/hudson/model/ListViewTest.java
          http://jenkins-ci.org/commit/jenkins/49de269da88ff5aad87ef5971f0754816a308ae0
          Log:
          Merge pull request #3039 from liketic/bugfix/pull/3007

          [Fix JENKINS-23411] Fix testing failure introduced in PR-3007

          Compare: https://github.com/jenkinsci/jenkins/compare/3adfed4b06a7...49de269da88f

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: test/src/test/java/hudson/model/ListViewTest.java http://jenkins-ci.org/commit/jenkins/49de269da88ff5aad87ef5971f0754816a308ae0 Log: Merge pull request #3039 from liketic/bugfix/pull/3007 [Fix JENKINS-23411] Fix testing failure introduced in PR-3007 Compare: https://github.com/jenkinsci/jenkins/compare/3adfed4b06a7...49de269da88f
          Hide
          danielbeck Daniel Beck added a comment -

          Merged towards 2.80.

          Show
          danielbeck Daniel Beck added a comment - Merged towards 2.80.

            People

            • Assignee:
              liketic Li Ke
              Reporter:
              oleg_nenashev Oleg Nenashev
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: