Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-23995

Adding commit status context in github-plugin

    Details

    • Similar Issues:

      Description

      The github-api seems to support the new commit status context in org.kohsuke.github.GHRepository. Are there any plans to use this option in com.cloudbees.jenkins.GitHubCommitNotifier?

        Attachments

          Activity

          Hide
          integer Kanstantsin Shautsou added a comment -

          You even didn't use new version, adding configuration for every thing will add useless complexity. Just name your job correctly.

          Show
          integer Kanstantsin Shautsou added a comment - You even didn't use new version, adding configuration for every thing will add useless complexity. Just name your job correctly.
          Hide
          urkle Edward Rudd added a comment -

          That is not really a constructive comment Kanstantsin. Several of us on this bug do not see it as useless complexity.. Naming our jobs "default" is not really a feasible practice. Especially if we have multiple different projects going on in our jenkins install.

          Having the ability to simply define what name we want it allows a better workflow especially when other systems are involved that look at these status values on github commits. We all have legitimate reasons for needing a customizable name for this status context.. IMHO this should be logged as a new issue so we can further discuss the needs there as a separate enhancement.

          Show
          urkle Edward Rudd added a comment - That is not really a constructive comment Kanstantsin. Several of us on this bug do not see it as useless complexity.. Naming our jobs "default" is not really a feasible practice. Especially if we have multiple different projects going on in our jenkins install. Having the ability to simply define what name we want it allows a better workflow especially when other systems are involved that look at these status values on github commits. We all have legitimate reasons for needing a customizable name for this status context.. IMHO this should be logged as a new issue so we can further discuss the needs there as a separate enhancement.
          Hide
          s0undt3ch Pedro Algarvio added a comment -

          I'm glad I didn't replied when I wanted to... I wouldn't have been that nice, still, I can't help it.... My jobs are named the way I think is correct. I shouldn't make my job naming convention change because of a plugin.

          Honestly, what's the extra complexity about having yet another config var per job?

          Show
          s0undt3ch Pedro Algarvio added a comment - I'm glad I didn't replied when I wanted to... I wouldn't have been that nice, still, I can't help it.... My jobs are named the way I think is correct. I shouldn't make my job naming convention change because of a plugin. Honestly, what's the extra complexity about having yet another config var per job?
          Hide
          s0undt3ch Pedro Algarvio added a comment -

          Let's resume discussion in https://issues.jenkins-ci.org/browse/JENKINS-27154 as suggested.

          Show
          s0undt3ch Pedro Algarvio added a comment - Let's resume discussion in https://issues.jenkins-ci.org/browse/JENKINS-27154 as suggested.
          Hide
          lanwen Kirill Merkushev added a comment -

          released in 1.14.1

          Show
          lanwen Kirill Merkushev added a comment - released in 1.14.1

            People

            • Assignee:
              Unassigned
              Reporter:
              cr3 Marc Tardif
            • Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: