Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24110

NPE in hudson.model.Executor when a task creates null Executable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      jenkins-1.509.4...1.574
    • Similar Issues:

      Description

      The code in Executor does not check created tasks for null => NPE appears in logging procedures when calling executable.toString() in Executor::run(). This behavior causes hardly analyzable issues like JENKINS-18164

      The issue sometimes appears for MatrixConfiguration runs, but according to the code it can be also reproduced in 1.574

      Console output for runs:

         Jul 31, 2014 3:04:19 PM hudson.model.Executor run
         SEVERE: Executor threw an exception
         java.lang.NullPointerException
                 at hudson.model.Executor.run(Executor.java:234)
      

        Attachments

          Issue Links

            Activity

            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3626
            [FIXED JENKINS-24110] - Explicitly handle null Executables in hudson.model.Executor (Revision 128344dda3a3396e252e9e00272093f233c0b9c9)
            JENKINS-24110 Noting merge of #1352. (Revision cbae95d60785722a8b35dd3158a911acb9b5d5ad)

            Result = UNSTABLE
            o.v.nenashev : 128344dda3a3396e252e9e00272093f233c0b9c9
            Files :

            • core/src/main/java/hudson/model/Queue.java
            • core/src/main/java/hudson/model/queue/QueueTaskFilter.java
            • core/src/main/java/hudson/model/ResourceController.java
            • core/src/main/java/hudson/model/queue/SubTask.java
            • core/src/main/java/hudson/model/queue/WorkUnit.java
            • core/src/main/java/hudson/model/AbstractProject.java
            • core/src/main/java/hudson/model/Executor.java

            Jesse Glick : cbae95d60785722a8b35dd3158a911acb9b5d5ad
            Files :

            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3626 [FIXED JENKINS-24110] - Explicitly handle null Executables in hudson.model.Executor (Revision 128344dda3a3396e252e9e00272093f233c0b9c9) JENKINS-24110 Noting merge of #1352. (Revision cbae95d60785722a8b35dd3158a911acb9b5d5ad) Result = UNSTABLE o.v.nenashev : 128344dda3a3396e252e9e00272093f233c0b9c9 Files : core/src/main/java/hudson/model/Queue.java core/src/main/java/hudson/model/queue/QueueTaskFilter.java core/src/main/java/hudson/model/ResourceController.java core/src/main/java/hudson/model/queue/SubTask.java core/src/main/java/hudson/model/queue/WorkUnit.java core/src/main/java/hudson/model/AbstractProject.java core/src/main/java/hudson/model/Executor.java Jesse Glick : cbae95d60785722a8b35dd3158a911acb9b5d5ad Files : changelog.html
            Hide
            oleg_nenashev Oleg Nenashev added a comment -

            Fixed in jenkins-1.577. I've marked the issue as lts-candidate

            Show
            oleg_nenashev Oleg Nenashev added a comment - Fixed in jenkins-1.577. I've marked the issue as lts-candidate
            Hide
            danielbeck Daniel Beck added a comment -

            next LTS will be based on 1.580, and the 1.565.x line is done.

            Show
            danielbeck Daniel Beck added a comment - next LTS will be based on 1.580, and the 1.565.x line is done.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/Executor.java
            http://jenkins-ci.org/commit/jenkins/8c7d06c72a64533482c45108abb600f8e462c710
            Log:
            Amend JENKINS-24110 fix to more politely specify what was not being run.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Executor.java http://jenkins-ci.org/commit/jenkins/8c7d06c72a64533482c45108abb600f8e462c710 Log: Amend JENKINS-24110 fix to more politely specify what was not being run.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/Executor.java
            http://jenkins-ci.org/commit/jenkins/d5d6eb037b51a69f86cbf105fd3b78178ad83611
            Log:
            Merge pull request #2963 from jglick/Executor-warning

            Amend JENKINS-24110 fix to more politely specify what was not being run

            Compare: https://github.com/jenkinsci/jenkins/compare/1c8ed8e672fe...d5d6eb037b51

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/Executor.java http://jenkins-ci.org/commit/jenkins/d5d6eb037b51a69f86cbf105fd3b78178ad83611 Log: Merge pull request #2963 from jglick/Executor-warning Amend JENKINS-24110 fix to more politely specify what was not being run Compare: https://github.com/jenkinsci/jenkins/compare/1c8ed8e672fe...d5d6eb037b51

              People

              • Assignee:
                oleg_nenashev Oleg Nenashev
                Reporter:
                oleg_nenashev Oleg Nenashev
              • Votes:
                1 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: