Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24141

SCM with non-AbstractProject, revisited

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      JENKINS-23365 made it possible to use SCM from other contexts. But there are still some SCM-oriented things stuck in AbstractProject/AbstractBuild which ought to be generalized.

      • AbstractBuild.getChangeSets (as used by project-changes.jelly) does not implement any method. Either this should be pushed up into Run so that it can be used more generally (simple though an awkward introduction of SCM specifics into Run); or SCMTriggerItem should add getChangeSets(Run) (more sensible architecturally, though awkward since it could not have a generic type for the build).
      • getCulprits and hasParticipant would seem to apply to any build with changes.
      • AbstractProject.doRssChangelog could be moved elsewhere and use getChangeSets.
      • View.AsynchPeople could use getChangeSets.

      Possibly there needs to be an interface for a Run with changes, tied somehow to SCMTriggerItem and with some default methods?

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            http://jenkins-ci.org/commit/workflow-job-plugin/5a72cab6c219491c62624e3971187d30beee1122
            Log:
            JENKINS-24141 Implement RunWithSCMMixIn.RunWithSCM

            Downstream of https://github.com/jenkinsci/jenkins/pull/2730

            More work to go, but this is the initial work.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java http://jenkins-ci.org/commit/workflow-job-plugin/5a72cab6c219491c62624e3971187d30beee1122 Log: JENKINS-24141 Implement RunWithSCMMixIn.RunWithSCM Downstream of https://github.com/jenkinsci/jenkins/pull/2730 More work to go, but this is the initial work.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            Jenkinsfile
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java
            src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java
            http://jenkins-ci.org/commit/workflow-job-plugin/70f444c6b696f84aeac9bd04239803ec73a2f4ad
            Log:
            Merge pull request #35 from abayer/jenkins-24141

            JENKINS-24141 Implement RunWithSCMMixIn.RunWithSCM

            Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/666a7102c6ef...70f444c6b696

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: Jenkinsfile pom.xml src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowRun.java src/test/java/org/jenkinsci/plugins/workflow/job/WorkflowRunTest.java http://jenkins-ci.org/commit/workflow-job-plugin/70f444c6b696f84aeac9bd04239803ec73a2f4ad Log: Merge pull request #35 from abayer/jenkins-24141 JENKINS-24141 Implement RunWithSCMMixIn.RunWithSCM Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/666a7102c6ef...70f444c6b696
            Hide
            jglick Jesse Glick added a comment -

            Released as workflow-job 2.12.

            Show
            jglick Jesse Glick added a comment - Released as workflow-job 2.12.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProvider.java
            src/main/java/hudson/plugins/emailext/plugins/recipients/RecipientProviderUtilities.java
            src/test/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProviderTest.java
            http://jenkins-ci.org/commit/email-ext-plugin/6cce465feef63af825fb4098483c3584c3251dfa
            Log:
            JENKINS-24141 Switch to using RunWithSCM for getCulprits logic

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProvider.java src/main/java/hudson/plugins/emailext/plugins/recipients/RecipientProviderUtilities.java src/test/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProviderTest.java http://jenkins-ci.org/commit/email-ext-plugin/6cce465feef63af825fb4098483c3584c3251dfa Log: JENKINS-24141 Switch to using RunWithSCM for getCulprits logic
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java
            src/main/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProvider.java
            src/main/java/hudson/plugins/emailext/plugins/recipients/RecipientProviderUtilities.java
            src/main/java/hudson/plugins/emailext/plugins/trigger/FailureTrigger.java
            src/test/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProviderTest.java
            src/test/java/hudson/plugins/emailext/plugins/recipients/DevelopersRecipientProviderTest.java
            src/test/java/hudson/plugins/emailext/plugins/recipients/FailingTestSuspectsRecipientProviderTest.java
            src/test/java/hudson/plugins/emailext/plugins/recipients/FirstFailingBuildSuspectsRecipientProviderTest.java
            src/test/java/hudson/plugins/emailext/plugins/recipients/MockUtilities.java
            http://jenkins-ci.org/commit/email-ext-plugin/dfb6bbbb995057049d9bb47b28a40621ebefeaef
            Log:
            Merge pull request #155 from abayer/jenkins-24141

            JENKINS-24141 Switch to using RunWithSCM for getCulprits logic

            Compare: https://github.com/jenkinsci/email-ext-plugin/compare/f0cc12d26052...dfb6bbbb9950

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/hudson/plugins/emailext/ExtendedEmailPublisherDescriptor.java src/main/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProvider.java src/main/java/hudson/plugins/emailext/plugins/recipients/RecipientProviderUtilities.java src/main/java/hudson/plugins/emailext/plugins/trigger/FailureTrigger.java src/test/java/hudson/plugins/emailext/plugins/recipients/CulpritsRecipientProviderTest.java src/test/java/hudson/plugins/emailext/plugins/recipients/DevelopersRecipientProviderTest.java src/test/java/hudson/plugins/emailext/plugins/recipients/FailingTestSuspectsRecipientProviderTest.java src/test/java/hudson/plugins/emailext/plugins/recipients/FirstFailingBuildSuspectsRecipientProviderTest.java src/test/java/hudson/plugins/emailext/plugins/recipients/MockUtilities.java http://jenkins-ci.org/commit/email-ext-plugin/dfb6bbbb995057049d9bb47b28a40621ebefeaef Log: Merge pull request #155 from abayer/jenkins-24141 JENKINS-24141 Switch to using RunWithSCM for getCulprits logic Compare: https://github.com/jenkinsci/email-ext-plugin/compare/f0cc12d26052...dfb6bbbb9950

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                jglick Jesse Glick
              • Votes:
                23 Vote for this issue
                Watchers:
                35 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: