Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24141

SCM with non-AbstractProject, revisited

    Details

    • Type: Task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Similar Issues:

      Description

      JENKINS-23365 made it possible to use SCM from other contexts. But there are still some SCM-oriented things stuck in AbstractProject/AbstractBuild which ought to be generalized.

      • AbstractBuild.getChangeSets (as used by project-changes.jelly) does not implement any method. Either this should be pushed up into Run so that it can be used more generally (simple though an awkward introduction of SCM specifics into Run); or SCMTriggerItem should add getChangeSets(Run) (more sensible architecturally, though awkward since it could not have a generic type for the build).
      • getCulprits and hasParticipant would seem to apply to any build with changes.
      • AbstractProject.doRssChangelog could be moved elsewhere and use getChangeSets.
      • View.AsynchPeople could use getChangeSets.

      Possibly there needs to be an interface for a Run with changes, tied somehow to SCMTriggerItem and with some default methods?

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                jglick Jesse Glick
              • Votes:
                23 Vote for this issue
                Watchers:
                37 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: