Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24329

Golang release json needs to be updated

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The plugin update.json file ( https://updates.jenkins-ci.org/updates/org.jenkinsci.plugins.golang.GolangInstaller.json ) is outdated and should be updated w/ the latests release. I would submit a PR on github but I can't figure out how the file on update.jenkins-ci.org gets generated from the github project.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Christopher Orr
          Path:
          golang.groovy
          http://jenkins-ci.org/commit/backend-crawler/5933fb929cb8e6064434a09e448b41a06a082bc0
          Log:
          [FIXED JENKINS-24329] Update Go crawler to handle download site changes.

          The download page now provides direct, absolute URLs and we're now more lenient
          about picking up links from the page, as the filename regex will handle things.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Christopher Orr Path: golang.groovy http://jenkins-ci.org/commit/backend-crawler/5933fb929cb8e6064434a09e448b41a06a082bc0 Log: [FIXED JENKINS-24329] Update Go crawler to handle download site changes. The download page now provides direct, absolute URLs and we're now more lenient about picking up links from the page, as the filename regex will handle things.
          Hide
          orrc Christopher Orr added a comment -

          Thanks for letting me know!

          The download page on golang.org changed with the 1.3.1 release, so the crawler missed out on 1.3.1 and 1.3 etc..

          This has been fixed now, and an updated file should automagically appear on updates.jenkins-ci.org within the next 24 hours.

          Show
          orrc Christopher Orr added a comment - Thanks for letting me know! The download page on golang.org changed with the 1.3.1 release, so the crawler missed out on 1.3.1 and 1.3 etc.. This has been fixed now, and an updated file should automagically appear on updates.jenkins-ci.org within the next 24 hours.
          Hide
          jgeiger Joey Geiger added a comment - - edited

          Sorry to re-open, but this has become an issue again.

          With the release of Go 1.10, the JSON is no longer parsed correctly.

           

          "name": "Go 1",
          "variants": [{
           "arch": "amd64",
           "os": "10.darwin",
           "url": "https://dl.google.com/go/go1.10.darwin-amd64.tar.gz" 
          }, { 
          

           

          The os is combining the version and os name.

          The UI only shows Go 1 as the downloadable version, but based on the OS, it doesn't look like it will properly work. This will also fail once go1.10.x is released as well.

          Here's a link to the full JSON.

          https://jenkins-updates.cloudbees.com/updates/org.jenkinsci.plugins.golang.GolangInstaller.json

           

          Thank you.

          Show
          jgeiger Joey Geiger added a comment - - edited Sorry to re-open, but this has become an issue again. With the release of Go 1.10, the JSON is no longer parsed correctly.   "name" : "Go 1" , "variants" : [{ "arch" : "amd64" , "os" : "10.darwin" , "url" : "https: //dl.google.com/go/go1.10.darwin-amd64.tar.gz" }, {    The os is combining the version and os name. The UI only shows Go 1 as the downloadable version, but based on the OS, it doesn't look like it will properly work. This will also fail once go1.10.x is released as well. Here's a link to the full JSON. https://jenkins-updates.cloudbees.com/updates/org.jenkinsci.plugins.golang.GolangInstaller.json   Thank you.
          Hide
          jgeiger Joey Geiger added a comment - - edited

          This needs to be updated in the crawler for the golang matcher.

           

          go(?:\.go)?(\d(?:\.\d{1,})*)\.(?:([^-]+)-([^-]+)(?:-(.+))?)\.(?:tar\.gz|zip)
          

           
          If you add the

          {1,}

          to the digit capture, it seems to work.

          Show
          jgeiger Joey Geiger added a comment - - edited This needs to be updated in the crawler for the golang matcher .   go(?:\.go)?(\d(?:\.\d{1,})*)\.(?:([^-]+)-([^-]+)(?:-(.+))?)\.(?:tar\.gz|zip)   If you add the {1,} to the digit capture, it seems to work.
          Hide
          orrc Christopher Orr added a comment -

          Thanks for reporting this. You can feel free to open a new issue, rather than reusing one that wasn't really related.

          I've submitted a PR here: https://github.com/jenkins-infra/crawler/pull/69

          Show
          orrc Christopher Orr added a comment - Thanks for reporting this. You can feel free to open a new issue, rather than reusing one that wasn't really related. I've submitted a PR here:  https://github.com/jenkins-infra/crawler/pull/69
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Daniel Beck
          Path:
          golang.groovy
          http://jenkins-ci.org/commit/crawler/654bc74bafebccbedb310c134b3b29bb7bcb63dc
          Log:
          Merge pull request #69 from orrc/fix-golang-version

          [FIXED JENKINS-24329] Fix golang crawler for double-digit versions

          Compare: https://github.com/jenkins-infra/crawler/compare/f9dd1e350526...654bc74bafeb

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: golang.groovy http://jenkins-ci.org/commit/crawler/654bc74bafebccbedb310c134b3b29bb7bcb63dc Log: Merge pull request #69 from orrc/fix-golang-version [FIXED JENKINS-24329] Fix golang crawler for double-digit versions Compare: https://github.com/jenkins-infra/crawler/compare/f9dd1e350526...654bc74bafeb

            People

            • Assignee:
              orrc Christopher Orr
              Reporter:
              johntdyer John Dyer
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: