Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24763

Long running OldDataMonitor.doDiscard() results in thread starvation

    Details

    • Similar Issues:

      Description

      A very large set of OldData can take a long time to discard. While this is running, most Jenkins operations which save any data are blocked.

      https://gist.github.com/recampbell/9336d3a32270e75a9333

      doDiscard is synchronized and hudson.diagnosis.OldDataMonitor#remove also wants to lock OldDataMonitor. Most threads eventually lock when saving something, at least until the doDiscard eventually completes.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            http://jenkins-ci.org/commit/jenkins/ef6c04244744670650fb36a4482e74daf2094f26
            Log:
            Merge branch 'JENKINS-24763' of github.com:recampbell/jenkins

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/diagnosis/OldDataMonitor.java test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java http://jenkins-ci.org/commit/jenkins/ef6c04244744670650fb36a4482e74daf2094f26 Log: Merge branch ' JENKINS-24763 ' of github.com:recampbell/jenkins
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/a8262d503e6af11feebac6005360d4db7639aff4
            Log:
            [FIXED JENKINS-24763] Noting merge of #1402.

            Compare: https://github.com/jenkinsci/jenkins/compare/3addbabf8afa...a8262d503e6a

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html http://jenkins-ci.org/commit/jenkins/a8262d503e6af11feebac6005360d4db7639aff4 Log: [FIXED JENKINS-24763] Noting merge of #1402. Compare: https://github.com/jenkinsci/jenkins/compare/3addbabf8afa...a8262d503e6a
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3738
            JENKINS-24763 Prevent thread starvation in OldDataMonitor by reducing scope of synchronization (Revision 423b51a43a3c2f469d12695c5fddcda52e97159e)
            [FIXED JENKINS-24763] Noting merge of #1402. (Revision a8262d503e6af11feebac6005360d4db7639aff4)

            Result = SUCCESS
            Ryan Campbell : 423b51a43a3c2f469d12695c5fddcda52e97159e
            Files :

            • test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            • core/src/main/java/hudson/diagnosis/OldDataMonitor.java

            Jesse Glick : a8262d503e6af11feebac6005360d4db7639aff4
            Files :

            • changelog.html
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3738 JENKINS-24763 Prevent thread starvation in OldDataMonitor by reducing scope of synchronization (Revision 423b51a43a3c2f469d12695c5fddcda52e97159e) [FIXED JENKINS-24763] Noting merge of #1402. (Revision a8262d503e6af11feebac6005360d4db7639aff4) Result = SUCCESS Ryan Campbell : 423b51a43a3c2f469d12695c5fddcda52e97159e Files : test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java core/src/main/java/hudson/diagnosis/OldDataMonitor.java Jesse Glick : a8262d503e6af11feebac6005360d4db7639aff4 Files : changelog.html
            Hide
            imakowski Ireneusz Makowski added a comment -

            Could you please add this also to lts?

            Show
            imakowski Ireneusz Makowski added a comment - Could you please add this also to lts?
            Hide
            danielbeck Daniel Beck added a comment -

            The 1.580.x line is done with the RC to 1.580.3 posted, and it will be in 1.596.x already.

            Show
            danielbeck Daniel Beck added a comment - The 1.580.x line is done with the RC to 1.580.3 posted, and it will be in 1.596.x already.

              People

              • Assignee:
                Unassigned
                Reporter:
                recampbell Ryan Campbell
              • Votes:
                1 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: