Details

    • Similar Issues:

      Description

      Accidents happen...

      It would be nice if the credentials introduced via this plugin were masked on the console output of a job log.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
            http://jenkins-ci.org/commit/credentials-binding-plugin/a47f4b8529fd216c3c797566aa969191834abd7a
            Log:
            JENKINS-24805 First work on masking secrets in freestyle logs.

            This still needs tests - I just want to make sure the approach is right.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java http://jenkins-ci.org/commit/credentials-binding-plugin/a47f4b8529fd216c3c797566aa969191834abd7a Log: JENKINS-24805 First work on masking secrets in freestyle logs. This still needs tests - I just want to make sure the approach is right.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java
            src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java
            src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java
            http://jenkins-ci.org/commit/credentials-binding-plugin/d2bcf977eb334ee93774c94d8db1007afc5cad41
            Log:
            Merge pull request #28 from abayer/jenkins-24805

            JENKINS-24805 Start masking secrets in freestyle logs.

            Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/686a29f57bf7...d2bcf977eb33

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: src/main/java/org/jenkinsci/plugins/credentialsbinding/MultiBinding.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/BindingStep.java src/main/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapper.java src/test/java/org/jenkinsci/plugins/credentialsbinding/impl/SecretBuildWrapperTest.java http://jenkins-ci.org/commit/credentials-binding-plugin/d2bcf977eb334ee93774c94d8db1007afc5cad41 Log: Merge pull request #28 from abayer/jenkins-24805 JENKINS-24805 Start masking secrets in freestyle logs. Compare: https://github.com/jenkinsci/credentials-binding-plugin/compare/686a29f57bf7...d2bcf977eb33
            Hide
            akostadinov akostadinov added a comment -

            Thanks a lot for implementing this! Which version of plug-in would have these changes?

            Show
            akostadinov akostadinov added a comment - Thanks a lot for implementing this! Which version of plug-in would have these changes?
            Hide
            abayer Andrew Bayer added a comment -

            It'll be in the next release, 1.10.

            Show
            abayer Andrew Bayer added a comment - It'll be in the next release, 1.10.
            Hide
            jglick Jesse Glick added a comment -

            …which is released.

            Show
            jglick Jesse Glick added a comment - …which is released.

              People

              • Assignee:
                abayer Andrew Bayer
                Reporter:
                walterk82 Walter Kacynski
              • Votes:
                13 Vote for this issue
                Watchers:
                22 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: