Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-24843

TAP Test Results Summary page shows 0ms for total even though there are non-zero durations

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: tap-plugin
    • Labels:
      None
    • Environment:
      TAP Plugin 1.20
      Jenkins 1.580
    • Similar Issues:

      Description

      Should the summary at the top right of the TAP Test Results page show the cumulative total duration for all detected TAP tests? I have configured a project to include duration timings, but the total indicates "Took 0 ms". An example screenshot is attached. Also, if I click on the "Took 0 ms" link, the history images are empty.

        Attachments

          Activity

          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hi Karl,

          I think it should. Let me experiment with it and check what's happening. I think you used YAMLish to report the times?

          Show
          kinow Bruno P. Kinoshita added a comment - Hi Karl, I think it should. Let me experiment with it and check what's happening. I think you used YAMLish to report the times?
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Hmmm, reproduced the issue. So far I have found out that

          a) we need better documentation about the duration for test results
          b) the diagnostics is not being persisted in the build action, and thus it is always displaying zeroes

          Show
          kinow Bruno P. Kinoshita added a comment - Hmmm, reproduced the issue. So far I have found out that a) we need better documentation about the duration for test results b) the diagnostics is not being persisted in the build action, and thus it is always displaying zeroes
          Hide
          kinow Bruno P. Kinoshita added a comment -

          Actually, I was looking at an older job I think. Investigating why the total is not the sum of the time of all the tests.

          Show
          kinow Bruno P. Kinoshita added a comment - Actually, I was looking at an older job I think. Investigating why the total is not the sum of the time of all the tests.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/java/org/tap4j/plugin/TapResult.java
          src/main/java/org/tap4j/plugin/model/TapStreamResult.java
          http://jenkins-ci.org/commit/tap-plugin/826be90000d4876cce1703449050e4a25b4c5423
          Log:
          JENKINS-24843 Add marker to where to add duration tally code

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/tap4j/plugin/TapResult.java src/main/java/org/tap4j/plugin/model/TapStreamResult.java http://jenkins-ci.org/commit/tap-plugin/826be90000d4876cce1703449050e4a25b4c5423 Log: JENKINS-24843 Add marker to where to add duration tally code
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/java/org/tap4j/plugin/TapResult.java
          src/main/java/org/tap4j/plugin/model/TapTestResultResult.java
          http://jenkins-ci.org/commit/tap-plugin/96365ab5f1d3eabc2c34e436dfa5ce826d6cfcbb
          Log:
          [FIXED JENKINS-24843] Copy duration from Tabulated Tests

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/java/org/tap4j/plugin/TapResult.java src/main/java/org/tap4j/plugin/model/TapTestResultResult.java http://jenkins-ci.org/commit/tap-plugin/96365ab5f1d3eabc2c34e436dfa5ce826d6cfcbb Log: [FIXED JENKINS-24843] Copy duration from Tabulated Tests
          Hide
          kinow Bruno P. Kinoshita added a comment -

          In order to fix it, I had to copy code that is being used in another part of the plug-in. I need to rethink the plug-in design to

          1) better support extend tap results and the default jenkins test results (added later)
          2) allow builds to scale to million of tests without performance issues

          Will include this fix in the next release, but watch out for a future 2.0 release, which may not be fully compatible with older jobs (though I promise I will try to use XStream auxiliary code to keep backward compatibility).

          Show
          kinow Bruno P. Kinoshita added a comment - In order to fix it, I had to copy code that is being used in another part of the plug-in. I need to rethink the plug-in design to 1) better support extend tap results and the default jenkins test results (added later) 2) allow builds to scale to million of tests without performance issues Will include this fix in the next release, but watch out for a future 2.0 release, which may not be fully compatible with older jobs (though I promise I will try to use XStream auxiliary code to keep backward compatibility).
          Hide
          kinow Bruno P. Kinoshita added a comment -

          2.0 Released

          Show
          kinow Bruno P. Kinoshita added a comment - 2.0 Released

            People

            • Assignee:
              kinow Bruno P. Kinoshita
              Reporter:
              koomietx Karl Schulz
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: