• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • p4-plugin
    • None

      Hi,

      I use the REST api's (json and XML) to process our Jenkins builds.

      The normal perforce plugin provides the following information in the changeSet list.

      "changeSet" : {
      "items" : [
      {
      "affectedPaths" : [
      "ma_tools/bin/stream_tester/cmd_stream_tester.exe",
      "ma_tools/bin/stream_tester/jenkins.dll",
      "ma_tools/bin/stream_tester/stream_tester.exe",
      "ma_tools/metrics/REST.py",
      "ma_tools/metrics/stat_upload.py"
      ],
      "author" :

      { "absoluteUrl" : "http://jenkins.gb-mlb.u-blox.net:8080/user/mjou", "fullName" : "mjou" }

      ,
      "commitId" : null,
      "msg" : "Copying //MA_SW/ci_tools to tools (//MA_SW/tools)",
      "timestamp" : -1,
      "changeNumber" : "71891",
      "changeTime" : "2014-11-10 17:54:01"
      },

      When i do the same REST calls on jobs using the p4 plugin some very important fields are missing.

      "changeSet" : {
      "items" : [
      {
      "affectedPaths" : null,
      "author" :

      { "absoluteUrl" : "http://jenkins.gb-mlb.u-blox.net:8080/user/mjou", "fullName" : "mjou" }

      ,
      "commitId" : null,
      "msg" : "U_MA_TLS-194 : Add option to email stream owners\nU_MA_TLS-188: Add option to create workspace per job\nU_MA_TLS-182: Fix bug with running status after job has completed\n",
      "timestamp" : -1
      }
      ],

      The important fields :
      "changeNumber" : "71891",
      "changeTime" : "2014-11-10 17:54:01"
      are missing.

      I have also noted that the affectedPaths is also null but this is of a lower priority than the changeNumber and changeTime.

          [JENKINS-25537] REST api provides incomplete information

          Morne Joubert added a comment -

          ok have a login on https://swarm.workshop.perforce.com/projects/p4-jenkins/ how do i get a shelve request in ?

          Morne Joubert added a comment - ok have a login on https://swarm.workshop.perforce.com/projects/p4-jenkins/ how do i get a shelve request in ?

          Paul Allen added a comment -

          Still have to use the good old fashioned p4/p4v client, although there are plans to make it more web friendly.

          Sync the code from public.perforce.com:1666 mapping //guest/perforce_software/p4jenkins/main/... in your workspace.

          Make your edits then shelve the files with a '#review' comment at the start of the description.

          Paul Allen added a comment - Still have to use the good old fashioned p4/p4v client, although there are plans to make it more web friendly. Sync the code from public.perforce.com:1666 mapping //guest/perforce_software/p4jenkins/main/... in your workspace. Make your edits then shelve the files with a '#review' comment at the start of the description.

          Morne Joubert added a comment -

          ok, i "think" i have done a pull request in the git system.

          let me know

          Morne Joubert added a comment - ok, i "think" i have done a pull request in the git system. let me know

          Paul Allen added a comment -

          Think you have two separate pull requests, let me take a look...

          Paul Allen added a comment - Think you have two separate pull requests, let me take a look...

          Morne Joubert added a comment -

          ah ok,

          have gone the git route via the browser... let me know if you want me to go the swarm route...

          Morne Joubert added a comment - ah ok, have gone the git route via the browser... let me know if you want me to go the swarm route...

          Paul Allen added a comment -

          Git is Ok – Just do one as I have to sync the other (Perforce in this case).

          Paul Allen added a comment - Git is Ok – Just do one as I have to sync the other (Perforce in this case).

          Morne Joubert added a comment -

          The latest version not has the correct REST fields

          Morne Joubert added a comment - The latest version not has the correct REST fields

          Paul Allen added a comment -

          I have not looked at this area of the code at all. Just took your changes as-is, is there a missing field or are the values incorrect? (is this related to the change number/shelf issue in JENKINS-25648)?

          Paul Allen added a comment - I have not looked at this area of the code at all. Just took your changes as-is, is there a missing field or are the values incorrect? (is this related to the change number/shelf issue in JENKINS-25648 )?

          Morne Joubert added a comment -

          I closed this since it was fixed by the change

          Morne Joubert added a comment - I closed this since it was fixed by the change

          Morne Joubert added a comment -

          It is not related to the other issue

          Morne Joubert added a comment - It is not related to the other issue

            Unassigned Unassigned
            mornejoubert Morne Joubert
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: