Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25744

Change delivery-pipeline job property from using section to an optionalBlock

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Normal convention for Jenkins plugins which contribute a JobProperty to a jobs configuration page is to use an optionalBlock as the top level jelly tag. This is presented to the user as a checkbox, allowing users to hide configuration from plugins they are not using which helps keep a jobs configuration page clean.

      The delivery-pipeline-plugin breaks this convention by using a section as it's top level jelly tag, which presents itself as a new header section.
      The biggest problem with this is, the delivery-pipeline-plugin seems to get rendered in the middle of all the other jobs properties therefore breaking up the page and making the jobs configuration look messy.

      I feel the delivery-pipeline-plugin would look feel/look better if it used the conventional optionalBlock.

        Attachments

          Issue Links

            Activity

            Hide
            fluffy88 Seán Dunne added a comment -

            Linked to pull request

            Show
            fluffy88 Seán Dunne added a comment - Linked to pull request
            Hide
            patbos Patrik Boström added a comment -

            Merged to master

            Show
            patbos Patrik Boström added a comment - Merged to master
            Hide
            patbos Patrik Boström added a comment -

            Released in 0.8.8

            Show
            patbos Patrik Boström added a comment - Released in 0.8.8

              People

              • Assignee:
                fluffy88 Seán Dunne
                Reporter:
                fluffy88 Seán Dunne
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: