Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-25886

Implement job configuration check - explicitly named remotes for MultiSCM (our case 12401)

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      If using MultiScm plugin, every git repository must be named explicitly in the "Name" field for the repository configuration in the job.

      The name must be job-wide unique.

      If using the ordinary git plugin, without MultiScm pluging we allow un-named repositories, as these will be implicitly named by the git plugin.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Mads Nielsen
          Path:
          src/main/java/org/jenkinsci/plugins/pretestedintegration/AbstractSCMBridge.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/IntegrationStrategy.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/PretestedIntegrationAction.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/PretestedIntegrationBuildWrapper.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/exceptions/NextCommitFailureException.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/exceptions/UnsupportedConfigurationException.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/AccumulatedCommitStrategy.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/SquashCommitStrategy.java
          src/main/resources/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge/help-branch.html
          src/main/resources/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge/help-repoName.html
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/AccumulatedCommitStrategyIT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/DoNotAllowMasterBranchAsReadyBranch.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/GeneralBehaviourIT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/JENKINS_24754_IT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/JENKINS_25546_IT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/MultipleScmIT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/SquashCommitStrategyIT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TestUtilsFactory.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TwoBranchHeadsIT.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/UniqueBranchGenerator.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/AbstractSCMBridgeTest.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/CommitTest.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/DummyCommit.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/DummyIntegrationStrategy.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/PretestedIntegrationActionTest.java
          http://jenkins-ci.org/commit/pretested-integration-plugin/703a6ca9f17a2e02b268306ac7a69a936841ae8e
          Log:
          JENKINS-25886: Job config and build data selection:

          Refactoring and implemented job configuration check to ensure explicit
          named remotes if using MultiScm plugin.

          Refactoring and improvements:

          • Safer and simpler selection of build data, so dublicates are accepted
            if identical, ambiguity is avoided and reported as failure
          • Refactoring methods changed interfaces, and is fixed.
          • Unit tests is updated.
          • Functional tests updated to match new error messages (no logic change)
          • One functional tests updated to new use case, it tested now invalid
            configuration.
          • Documentation notes are added to some functions.
          • UI help text updated with "no trailing slash"-tip
          • Functional tests now have headers explaining what is tested.
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Mads Nielsen Path: src/main/java/org/jenkinsci/plugins/pretestedintegration/AbstractSCMBridge.java src/main/java/org/jenkinsci/plugins/pretestedintegration/IntegrationStrategy.java src/main/java/org/jenkinsci/plugins/pretestedintegration/PretestedIntegrationAction.java src/main/java/org/jenkinsci/plugins/pretestedintegration/PretestedIntegrationBuildWrapper.java src/main/java/org/jenkinsci/plugins/pretestedintegration/exceptions/NextCommitFailureException.java src/main/java/org/jenkinsci/plugins/pretestedintegration/exceptions/UnsupportedConfigurationException.java src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/AccumulatedCommitStrategy.java src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge.java src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/SquashCommitStrategy.java src/main/resources/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge/help-branch.html src/main/resources/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge/help-repoName.html src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/AccumulatedCommitStrategyIT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/DoNotAllowMasterBranchAsReadyBranch.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/GeneralBehaviourIT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/JENKINS_24754_IT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/JENKINS_25546_IT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/MultipleScmIT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/SquashCommitStrategyIT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TestUtilsFactory.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/TwoBranchHeadsIT.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/UniqueBranchGenerator.java src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/AbstractSCMBridgeTest.java src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/CommitTest.java src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/DummyCommit.java src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/DummyIntegrationStrategy.java src/test/java/org/jenkinsci/plugins/pretestedintegration/unit/PretestedIntegrationActionTest.java http://jenkins-ci.org/commit/pretested-integration-plugin/703a6ca9f17a2e02b268306ac7a69a936841ae8e Log: JENKINS-25886 : Job config and build data selection: Refactoring and implemented job configuration check to ensure explicit named remotes if using MultiScm plugin. Refactoring and improvements: Safer and simpler selection of build data, so dublicates are accepted if identical, ambiguity is avoided and reported as failure Refactoring methods changed interfaces, and is fixed. Unit tests is updated. Functional tests updated to match new error messages (no logic change) One functional tests updated to new use case, it tested now invalid configuration. Documentation notes are added to some functions. UI help text updated with "no trailing slash"-tip Functional tests now have headers explaining what is tested.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bue Petersen
          Path:
          src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge.java
          src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/DoNotAllowMasterBranchAsReadyBranch.java
          http://jenkins-ci.org/commit/pretested-integration-plugin/aa41c562c70e174e7177dd058b401243ddbc9d52
          Log:
          JENKINS-25886: Minor java 1.6-1.7 compatibility fix to make javancss reporting work

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bue Petersen Path: src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/GitBridge.java src/test/java/org/jenkinsci/plugins/pretestedintegration/integration/scm/git/DoNotAllowMasterBranchAsReadyBranch.java http://jenkins-ci.org/commit/pretested-integration-plugin/aa41c562c70e174e7177dd058b401243ddbc9d52 Log: JENKINS-25886 : Minor java 1.6-1.7 compatibility fix to make javancss reporting work
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Bue Petersen
          Path:
          src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/AccumulatedCommitStrategy.java
          src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/SquashCommitStrategy.java
          http://jenkins-ci.org/commit/pretested-integration-plugin/70cc37d93546425d40c64a9bec4a500f5206f098
          Log:
          JENKINS-25886: Change back unintented minor change.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bue Petersen Path: src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/AccumulatedCommitStrategy.java src/main/java/org/jenkinsci/plugins/pretestedintegration/scm/git/SquashCommitStrategy.java http://jenkins-ci.org/commit/pretested-integration-plugin/70cc37d93546425d40c64a9bec4a500f5206f098 Log: JENKINS-25886 : Change back unintented minor change.

            People

            • Assignee:
              bue Bue Petersen
              Reporter:
              bue Bue Petersen
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: