Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26005

"Run condition trigger" for Email-ext does not retain "Send To" information on Save/Apply

    Details

    • Similar Issues:

      Description

      • Create new "Freestyle Project"
      • Choose "Editable Email Notification" from "Post-build Actions"
      • Click "Advanced Settings..."
      • Click "Add Trigger"
      • Select "Run condition trigger"
      • Click "Add" for "Send To" of "Run condition trigger"
      • Choose "Recipient List" (or any other)
      • Click "Advanced..." of "Run condition trigger"
      • Select "Run Condition" (can leave at "Always")
      • Click Jenkins "Save" or "Apply"
      • Leave the page, and return to the same configuration

      Expected result:

      • All configuration was saved, "send to" has a list of selected recipients.

      Actual result:

      • Most configuration was saved, "send to" list has been cleared.

      Please note this only happens for "Run condition trigger". Other triggers save correctly

        Attachments

          Activity

          Hide
          slide_o_mix Alex Earl added a comment -

          The "run condition trigger" is not part of the email-ext plugin. It is part of the run-condition-extras plugin.

          Show
          slide_o_mix Alex Earl added a comment - The "run condition trigger" is not part of the email-ext plugin. It is part of the run-condition-extras plugin.
          Hide
          sullivac Corey Sullivan added a comment -

          Created a pull request that changes the constructor of RunConditionEmailTrigger to the newer signature. The newer email-ext version has a different signature for the @DataBoundConstructor-decorated constructor.

          https://github.com/jenkinsci/run-condition-extras-plugin/pull/1

          Show
          sullivac Corey Sullivan added a comment - Created a pull request that changes the constructor of RunConditionEmailTrigger to the newer signature. The newer email-ext version has a different signature for the @DataBoundConstructor-decorated constructor. https://github.com/jenkinsci/run-condition-extras-plugin/pull/1
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Corey Sullivan
          Path:
          pom.xml
          src/main/java/com/synopsys/arc/jenkinsci/plugins/run_condition_extras/adapters/mail_ext/RunConditionEmailTrigger.java
          http://jenkins-ci.org/commit/run-condition-extras-plugin/19588e6e57c2950ec9559e550345e5d723d1355a
          Log:
          Modify the constructor of RunConditionEmailTrigger to call the non-deprecated constructor.
          The constructor that passes boolean parameters for the "Send To" list has been deprecated as 2.38 (email-ext.)
          Fix for JENKINS-26005.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Corey Sullivan Path: pom.xml src/main/java/com/synopsys/arc/jenkinsci/plugins/run_condition_extras/adapters/mail_ext/RunConditionEmailTrigger.java http://jenkins-ci.org/commit/run-condition-extras-plugin/19588e6e57c2950ec9559e550345e5d723d1355a Log: Modify the constructor of RunConditionEmailTrigger to call the non-deprecated constructor. The constructor that passes boolean parameters for the "Send To" list has been deprecated as 2.38 (email-ext.) Fix for JENKINS-26005 .
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/com/synopsys/arc/jenkinsci/plugins/run_condition_extras/adapters/mail_ext/RunConditionEmailTrigger.java
          http://jenkins-ci.org/commit/run-condition-extras-plugin/9ff4683beae73af83f39c02048c6ab629c9251e9
          Log:
          Merge pull request #1 from sullivac/master

          [FIXED JENKINS-26005] - Modify the constructor of RunConditionEmailTrigger to call the non-depre...

          Compare: https://github.com/jenkinsci/run-condition-extras-plugin/compare/02c2f42e5477...9ff4683beae7

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/com/synopsys/arc/jenkinsci/plugins/run_condition_extras/adapters/mail_ext/RunConditionEmailTrigger.java http://jenkins-ci.org/commit/run-condition-extras-plugin/9ff4683beae73af83f39c02048c6ab629c9251e9 Log: Merge pull request #1 from sullivac/master [FIXED JENKINS-26005] - Modify the constructor of RunConditionEmailTrigger to call the non-depre... Compare: https://github.com/jenkinsci/run-condition-extras-plugin/compare/02c2f42e5477...9ff4683beae7

            People

            • Assignee:
              oleg_nenashev Oleg Nenashev
              Reporter:
              slavd slav dok
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: