Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26059

Expand variables before using conditional

    Details

    • Similar Issues:

      Description

      A few parts in the code check for a variable being null, then execute some code.
      However, when using Parameters, the value itself won't be null, but if that parameter then expands to an empty string it would be equivalent of null.
      For example: In
      https://github.com/jenkinsci/hockeyapp-plugin/blob/master/src/main/java/hockeyapp/HockeyappRecorder.java#L216

      Checking dsymPath for null would return "$SYMBOLEFILES" as not null; however, if a build is parameterized and that value is empty, it would be equivalent of null when expanded on line 217/218

      Therefore, should be expanded before checking.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Brenton Bartel
          Path:
          src/main/java/hockeyapp/HockeyappRecorder.java
          http://jenkins-ci.org/commit/hockeyapp-plugin/51c211eb03e5e51e80649bf26e146a5d5025bac3
          Log:
          Effort to tackle https://issues.jenkins-ci.org/browse/JENKINS-26059 to expand var during conditional

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Brenton Bartel Path: src/main/java/hockeyapp/HockeyappRecorder.java http://jenkins-ci.org/commit/hockeyapp-plugin/51c211eb03e5e51e80649bf26e146a5d5025bac3 Log: Effort to tackle https://issues.jenkins-ci.org/browse/JENKINS-26059 to expand var during conditional
          Show
          brantone Brantone added a comment - https://github.com/jenkinsci/hockeyapp-plugin/pull/27
          Hide
          brantone Brantone added a comment -

          IN 1.2.1

          Show
          brantone Brantone added a comment - IN 1.2.1

            People

            • Assignee:
              brantone Brantone
              Reporter:
              brantone Brantone
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: