-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: hockeyapp-plugin
-
Labels:None
-
Similar Issues:
A few parts in the code check for a variable being null, then execute some code.
However, when using Parameters, the value itself won't be null, but if that parameter then expands to an empty string it would be equivalent of null.
For example: In
https://github.com/jenkinsci/hockeyapp-plugin/blob/master/src/main/java/hockeyapp/HockeyappRecorder.java#L216
Checking dsymPath for null would return "$SYMBOLEFILES" as not null; however, if a build is parameterized and that value is empty, it would be equivalent of null when expanded on line 217/218
Therefore, should be expanded before checking.
Code changed in jenkins
User: Brenton Bartel
Path:
src/main/java/hockeyapp/HockeyappRecorder.java
http://jenkins-ci.org/commit/hockeyapp-plugin/51c211eb03e5e51e80649bf26e146a5d5025bac3
Log:
Effort to tackle https://issues.jenkins-ci.org/browse/JENKINS-26059 to expand var during conditional