Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26227

xUnit plugin doesn't use OS culture when reads time values in xUnit.net output

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: xunit-plugin
    • Labels:
      None
    • Environment:
      plugin version 1.93
      Jenkins version 1.595
    • Similar Issues:

      Description

      If decimal symbol is a comma (for example that is the case in the russian culture) then xUnit plugin treats this incorrectly. For example 0,031 becomes 31 seconds instead of 31 milliseconds and 1,200 becomes 20 minutes instead of 1 second and 200 milliseconds.
      xUnit.net produces decimals with respect to current system culture and this inconsistency is the cause of the described problem.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Nikolas Falco
          Path:
          src/main/resources/org/jenkinsci/plugins/xunit/types/cpptestunit-2.0-to-junit-1.0.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/ctest-to-junit.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/mbunit-to-junit-4.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/mstest-1.0-to-junit-1.0.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/nunit-1.0-to-junit-2.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/nunit-3.0-to-junit.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/phpunit-1.0-to-junit-4.0.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/qtestlib-5.0-to-junit-1.0.xsl
          src/main/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet-2.0-to-junit-2.xsl
          src/test/java/org/jenkinsci/plugins/xunit/types/PHPUnitTest.java
          src/test/java/org/jenkinsci/plugins/xunit/types/XUnitDotNetTest.java
          src/test/java/org/jenkinsci/plugins/xunit/types/XunitDotNetTest.java
          src/test/resources/org/jenkinsci/plugins/xunit/types/junit/testcase3/input.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/input.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/junit-simple.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/result.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/xunit-simple.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/input.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/junit-simple.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/result.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/xunit-simple.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase3/input.xml
          src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase3/result.xml
          http://jenkins-ci.org/commit/xunit-plugin/850a7bbfb4ab2dfac188756652cdb19ab3d6ffd8
          Log:
          JENKINS-26227 xUnit plugin doesn't use OS culture when reads time values in xUnit.net output

          To be aware from OS culture the junit-time function converts input from any type to string, replace comma with a dot and use its double value to format millisend time to the correct JUnit format.

          *NOTE:* This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

          Functionality will be removed from GitHub.com on January 31st, 2019.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Nikolas Falco Path: src/main/resources/org/jenkinsci/plugins/xunit/types/cpptestunit-2.0-to-junit-1.0.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/ctest-to-junit.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/mbunit-to-junit-4.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/mstest-1.0-to-junit-1.0.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/nunit-1.0-to-junit-2.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/nunit-3.0-to-junit.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/phpunit-1.0-to-junit-4.0.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/qtestlib-5.0-to-junit-1.0.xsl src/main/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet-2.0-to-junit-2.xsl src/test/java/org/jenkinsci/plugins/xunit/types/PHPUnitTest.java src/test/java/org/jenkinsci/plugins/xunit/types/XUnitDotNetTest.java src/test/java/org/jenkinsci/plugins/xunit/types/XunitDotNetTest.java src/test/resources/org/jenkinsci/plugins/xunit/types/junit/testcase3/input.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/input.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/junit-simple.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/result.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase1/xunit-simple.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/input.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/junit-simple.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/result.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase2/xunit-simple.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase3/input.xml src/test/resources/org/jenkinsci/plugins/xunit/types/xunitdotnet/testcase3/result.xml http://jenkins-ci.org/commit/xunit-plugin/850a7bbfb4ab2dfac188756652cdb19ab3d6ffd8 Log: JENKINS-26227 xUnit plugin doesn't use OS culture when reads time values in xUnit.net output To be aware from OS culture the junit-time function converts input from any type to string, replace comma with a dot and use its double value to format millisend time to the correct JUnit format. * NOTE: * This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

            People

            • Assignee:
              nfalco Nikolas Falco
              Reporter:
              hinidu Pavel Platto
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: