Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26233

provide badge for github pull request builder plugin

    Details

    • Similar Issues:

      Description

      Currently builds on pull requests get the default question mark badge. Would be nice if they got the Github PR icon badge.

        Attachments

          Activity

          Hide
          batmat Baptiste Mathus added a comment -

          Thanks for reporting. Please (always) specify informations like the plugin version, Jenkins version, and possibly some informations about the execution platform. That'd help identify and fix issues when confirmed.

          Even better, submit a pull request, obviously . Adding an icon for a specific cause is dead simple in this plugin, see this class: https://github.com/jenkinsci/buildtriggerbadge-plugin/blob/master/src/main/java/org/jenkinsci/plugins/buildtriggerbadge/BuildTriggerBadgeAction.java#L78

          Though as you can see in the link, Github pushes should already be supported, hence the details required. Thanks.

          Show
          batmat Baptiste Mathus added a comment - Thanks for reporting. Please (always) specify informations like the plugin version, Jenkins version, and possibly some informations about the execution platform. That'd help identify and fix issues when confirmed. Even better, submit a pull request, obviously . Adding an icon for a specific cause is dead simple in this plugin, see this class: https://github.com/jenkinsci/buildtriggerbadge-plugin/blob/master/src/main/java/org/jenkinsci/plugins/buildtriggerbadge/BuildTriggerBadgeAction.java#L78 Though as you can see in the link, Github pushes should already be supported, hence the details required. Thanks.
          Hide
          corbosman Cor Bosman added a comment - - edited

          Hi, thanks for responding. Im fairly new at Jenkins and Java.

          Plugin version 1.3, Jenkins 1.595, on a debian server. Github Requests come from a Github Enterprise installation. Im using a plugin named "Github Pull Request Builder".

          This plugin fires off job triggers based on Pull Requests. So not normal commits/pushes.

          The section from Github: http://wa.ter.net/download/skitch/Pull_Requests_%C2%B7_XS4ALL_PRtest-20150101-172423.jpg

          Relevant part of the logfile:

          Jan 01, 2015 5:14:19 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
          Got payload event: pull_request
          Jan 01, 2015 5:14:19 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex
          Checking PR #6 for XS4ALL/PRtest
          Jan 01, 2015 5:14:19 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest
          Created Pull Request #6 on xxxx/PRtest by cor (cor@xxxx) updated at: 1/1/15 5:14 PM SHA: c3e8acdc46b3d1863a5f1055378035af342d6527
          Jan 01, 2015 5:14:20 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository createCommitStatus
          Setting status of c3e8acdc46b3d1863a5f1055378035af342d6527 to PENDING with url null and message: Merge build triggered.
          Jan 01, 2015 5:14:20 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest build
          Merge build triggered.
          Jan 01, 2015 5:14:25 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository createCommitStatus
          Setting status of c3e8acdc46b3d1863a5f1055378035af342d6527 to PENDING with url https://xxxxx/job/Pull%20Request%20Test/16/ and message: Merged build started.
          Jan 01, 2015 5:14:29 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository createCommitStatus
          Setting status of c3e8acdc46b3d1863a5f1055378035af342d6527 to FAILURE with url https://xxxxx/job/Pull%20Request%20Test/16/ and message: Merged build finished.

          Show
          corbosman Cor Bosman added a comment - - edited Hi, thanks for responding. Im fairly new at Jenkins and Java. Plugin version 1.3, Jenkins 1.595, on a debian server. Github Requests come from a Github Enterprise installation. Im using a plugin named "Github Pull Request Builder". This plugin fires off job triggers based on Pull Requests. So not normal commits/pushes. The section from Github: http://wa.ter.net/download/skitch/Pull_Requests_%C2%B7_XS4ALL_PRtest-20150101-172423.jpg Relevant part of the logfile: Jan 01, 2015 5:14:19 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex Got payload event: pull_request Jan 01, 2015 5:14:19 PM INFO org.jenkinsci.plugins.ghprb.GhprbRootAction doIndex Checking PR #6 for XS4ALL/PRtest Jan 01, 2015 5:14:19 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest Created Pull Request #6 on xxxx/PRtest by cor (cor@xxxx) updated at: 1/1/15 5:14 PM SHA: c3e8acdc46b3d1863a5f1055378035af342d6527 Jan 01, 2015 5:14:20 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository createCommitStatus Setting status of c3e8acdc46b3d1863a5f1055378035af342d6527 to PENDING with url null and message: Merge build triggered. Jan 01, 2015 5:14:20 PM INFO org.jenkinsci.plugins.ghprb.GhprbPullRequest build Merge build triggered. Jan 01, 2015 5:14:25 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository createCommitStatus Setting status of c3e8acdc46b3d1863a5f1055378035af342d6527 to PENDING with url https://xxxxx/job/Pull%20Request%20Test/16/ and message: Merged build started. Jan 01, 2015 5:14:29 PM INFO org.jenkinsci.plugins.ghprb.GhprbRepository createCommitStatus Setting status of c3e8acdc46b3d1863a5f1055378035af342d6527 to FAILURE with url https://xxxxx/job/Pull%20Request%20Test/16/ and message: Merged build finished.
          Hide
          batmat Baptiste Mathus added a comment -

          OK, I had a look, the relevant information is here: https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbCause.java

          Should be easy to add. I'll do it soon and release asap.

          Cheers

          Show
          batmat Baptiste Mathus added a comment - OK, I had a look, the relevant information is here: https://github.com/jenkinsci/ghprb-plugin/blob/master/src/main/java/org/jenkinsci/plugins/ghprb/GhprbCause.java Should be easy to add. I'll do it soon and release asap. Cheers
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Baptiste Mathus
          Path:
          src/main/java/org/jenkinsci/plugins/buildtriggerbadge/BuildTriggerBadgeAction.java
          src/main/webapp/images/github-pull-request-cause.png
          http://jenkins-ci.org/commit/buildtriggerbadge-plugin/6c54fc963dd65d501ca34d550ed4f3b9e3f12577
          Log:
          [Fixed JENKINS-26233] provide badge for github pull request builder plugin

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: src/main/java/org/jenkinsci/plugins/buildtriggerbadge/BuildTriggerBadgeAction.java src/main/webapp/images/github-pull-request-cause.png http://jenkins-ci.org/commit/buildtriggerbadge-plugin/6c54fc963dd65d501ca34d550ed4f3b9e3f12577 Log: [Fixed JENKINS-26233] provide badge for github pull request builder plugin
          Hide
          batmat Baptiste Mathus added a comment -

          6c54fc963dd65d501ca34d550ed4f3b9e3f12577

          Show
          batmat Baptiste Mathus added a comment - 6c54fc963dd65d501ca34d550ed4f3b9e3f12577

            People

            • Assignee:
              batmat Baptiste Mathus
              Reporter:
              corbosman Cor Bosman
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: