Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26281

Allow users to delete builds even if they are supposed to be kept

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      Any Run with isKeepLog==true can not be deleted from UI. Allow such deletions but user must be made aware and explicitly confirm.

      Originally suggested by vjuranek https://github.com/jenkinsci/jenkins/pull/552#issuecomment-8220136.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/resources/hudson/model/Run/confirmDelete.jelly
            core/src/main/resources/hudson/model/Run/confirmDelete.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_da.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_de.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_es.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_fr.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_ja.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_nl.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_pt_BR.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_ru.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_tr.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_zh_TW.properties
            http://jenkins-ci.org/commit/jenkins/818ae76af82e8cb3f25cfbb83d42812c80809bab
            Log:
            [FIXED JENKINS-26281] Allow users to delete builds even if they are supposed to be kept

            This expects that any mechanism that keeps builds handles their disappearance gracefully.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/resources/hudson/model/Run/confirmDelete.jelly core/src/main/resources/hudson/model/Run/confirmDelete.properties core/src/main/resources/hudson/model/Run/confirmDelete_da.properties core/src/main/resources/hudson/model/Run/confirmDelete_de.properties core/src/main/resources/hudson/model/Run/confirmDelete_es.properties core/src/main/resources/hudson/model/Run/confirmDelete_fr.properties core/src/main/resources/hudson/model/Run/confirmDelete_ja.properties core/src/main/resources/hudson/model/Run/confirmDelete_nl.properties core/src/main/resources/hudson/model/Run/confirmDelete_pt_BR.properties core/src/main/resources/hudson/model/Run/confirmDelete_ru.properties core/src/main/resources/hudson/model/Run/confirmDelete_tr.properties core/src/main/resources/hudson/model/Run/confirmDelete_zh_TW.properties http://jenkins-ci.org/commit/jenkins/818ae76af82e8cb3f25cfbb83d42812c80809bab Log: [FIXED JENKINS-26281] Allow users to delete builds even if they are supposed to be kept This expects that any mechanism that keeps builds handles their disappearance gracefully.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            core/src/main/resources/hudson/model/Run/confirmDelete.jelly
            core/src/main/resources/hudson/model/Run/confirmDelete.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_da.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_de.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_es.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_fr.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_ja.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_nl.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_pt_BR.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_ru.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_tr.properties
            core/src/main/resources/hudson/model/Run/confirmDelete_zh_TW.properties
            http://jenkins-ci.org/commit/jenkins/50f940009b3eda003ff59ecdb21816b00be19339
            Log:
            Merge pull request #1511 from olivergondza/override-whyKeepLog

            JENKINS-26281 Allow users to delete builds even if they are supposed to be kept

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: core/src/main/resources/hudson/model/Run/confirmDelete.jelly core/src/main/resources/hudson/model/Run/confirmDelete.properties core/src/main/resources/hudson/model/Run/confirmDelete_da.properties core/src/main/resources/hudson/model/Run/confirmDelete_de.properties core/src/main/resources/hudson/model/Run/confirmDelete_es.properties core/src/main/resources/hudson/model/Run/confirmDelete_fr.properties core/src/main/resources/hudson/model/Run/confirmDelete_ja.properties core/src/main/resources/hudson/model/Run/confirmDelete_nl.properties core/src/main/resources/hudson/model/Run/confirmDelete_pt_BR.properties core/src/main/resources/hudson/model/Run/confirmDelete_ru.properties core/src/main/resources/hudson/model/Run/confirmDelete_tr.properties core/src/main/resources/hudson/model/Run/confirmDelete_zh_TW.properties http://jenkins-ci.org/commit/jenkins/50f940009b3eda003ff59ecdb21816b00be19339 Log: Merge pull request #1511 from olivergondza/override-whyKeepLog JENKINS-26281 Allow users to delete builds even if they are supposed to be kept
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3925
            [FIXED JENKINS-26281] Allow users to delete builds even if they are supposed to be kept (Revision 818ae76af82e8cb3f25cfbb83d42812c80809bab)

            Result = SUCCESS
            ogondza : 818ae76af82e8cb3f25cfbb83d42812c80809bab
            Files :

            • core/src/main/resources/hudson/model/Run/confirmDelete_tr.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_ru.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_pt_BR.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_es.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_ja.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_fr.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete.jelly
            • core/src/main/resources/hudson/model/Run/confirmDelete_zh_TW.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_da.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_nl.properties
            • core/src/main/resources/hudson/model/Run/confirmDelete_de.properties
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3925 [FIXED JENKINS-26281] Allow users to delete builds even if they are supposed to be kept (Revision 818ae76af82e8cb3f25cfbb83d42812c80809bab) Result = SUCCESS ogondza : 818ae76af82e8cb3f25cfbb83d42812c80809bab Files : core/src/main/resources/hudson/model/Run/confirmDelete_tr.properties core/src/main/resources/hudson/model/Run/confirmDelete_ru.properties core/src/main/resources/hudson/model/Run/confirmDelete_pt_BR.properties core/src/main/resources/hudson/model/Run/confirmDelete_es.properties core/src/main/resources/hudson/model/Run/confirmDelete.properties core/src/main/resources/hudson/model/Run/confirmDelete_ja.properties core/src/main/resources/hudson/model/Run/confirmDelete_fr.properties core/src/main/resources/hudson/model/Run/confirmDelete.jelly core/src/main/resources/hudson/model/Run/confirmDelete_zh_TW.properties core/src/main/resources/hudson/model/Run/confirmDelete_da.properties core/src/main/resources/hudson/model/Run/confirmDelete_nl.properties core/src/main/resources/hudson/model/Run/confirmDelete_de.properties
            Hide
            jcechace Jakub Cechacek added a comment -

            Additional PR with further fixes send [1]. If applicable a warning about dependant builds is now displayed when user is prompted to confirm the delete action. However this warning does not prevent the deletion anymore and allows users to proceed by confirming the action.

            [1] https://github.com/jenkinsci/matrix-project-plugin/pull/39

            Show
            jcechace Jakub Cechacek added a comment - Additional PR with further fixes send [1] . If applicable a warning about dependant builds is now displayed when user is prompted to confirm the delete action. However this warning does not prevent the deletion anymore and allows users to proceed by confirming the action. [1] https://github.com/jenkinsci/matrix-project-plugin/pull/39
            Hide
            jcechace Jakub Cechacek added a comment -

            Additional PR to core [1] to hide the delete button when

            whyKeepLog != null 

            . In such cases the build can't be deleted anyway.

            [1] https://github.com/jenkinsci/jenkins/pull/2483

            Show
            jcechace Jakub Cechacek added a comment - Additional PR to core [1] to hide the delete button when whyKeepLog != null . In such cases the build can't be deleted anyway. [1] https://github.com/jenkinsci/jenkins/pull/2483
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jakub Cechacek
            Path:
            src/main/java/hudson/matrix/MatrixBuild.java
            src/main/java/hudson/matrix/MatrixRun.java
            src/main/resources/hudson/matrix/Messages.properties
            src/main/resources/hudson/matrix/Messages_da.properties
            src/main/resources/hudson/matrix/Messages_de.properties
            src/main/resources/hudson/matrix/Messages_es.properties
            src/main/resources/hudson/matrix/Messages_ja.properties
            src/main/resources/hudson/matrix/Messages_nl.properties
            src/main/resources/hudson/matrix/Messages_pt.properties
            src/main/resources/hudson/matrix/Messages_pt_BR.properties
            src/main/resources/hudson/matrix/Messages_tr.properties
            src/main/resources/hudson/matrix/Messages_zh_CN.properties
            src/main/resources/hudson/matrix/Messages_zh_TW.properties
            src/main/resources/hudson/model/Run/confirmDelete.jelly
            src/test/java/hudson/matrix/MatrixProjectTest.java
            http://jenkins-ci.org/commit/matrix-project-plugin/d341857b9e525297937c74c8bc0fdf79658fec16
            Log:
            JENKINS-26281 Matrix builds can be deleted

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jakub Cechacek Path: src/main/java/hudson/matrix/MatrixBuild.java src/main/java/hudson/matrix/MatrixRun.java src/main/resources/hudson/matrix/Messages.properties src/main/resources/hudson/matrix/Messages_da.properties src/main/resources/hudson/matrix/Messages_de.properties src/main/resources/hudson/matrix/Messages_es.properties src/main/resources/hudson/matrix/Messages_ja.properties src/main/resources/hudson/matrix/Messages_nl.properties src/main/resources/hudson/matrix/Messages_pt.properties src/main/resources/hudson/matrix/Messages_pt_BR.properties src/main/resources/hudson/matrix/Messages_tr.properties src/main/resources/hudson/matrix/Messages_zh_CN.properties src/main/resources/hudson/matrix/Messages_zh_TW.properties src/main/resources/hudson/model/Run/confirmDelete.jelly src/test/java/hudson/matrix/MatrixProjectTest.java http://jenkins-ci.org/commit/matrix-project-plugin/d341857b9e525297937c74c8bc0fdf79658fec16 Log: JENKINS-26281 Matrix builds can be deleted
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oliver Gondža
            Path:
            src/main/java/hudson/matrix/MatrixBuild.java
            src/main/java/hudson/matrix/MatrixRun.java
            src/main/resources/hudson/matrix/Messages.properties
            src/main/resources/hudson/matrix/Messages_da.properties
            src/main/resources/hudson/matrix/Messages_de.properties
            src/main/resources/hudson/matrix/Messages_es.properties
            src/main/resources/hudson/matrix/Messages_ja.properties
            src/main/resources/hudson/matrix/Messages_nl.properties
            src/main/resources/hudson/matrix/Messages_pt.properties
            src/main/resources/hudson/matrix/Messages_pt_BR.properties
            src/main/resources/hudson/matrix/Messages_tr.properties
            src/main/resources/hudson/matrix/Messages_zh_CN.properties
            src/main/resources/hudson/matrix/Messages_zh_TW.properties
            src/main/resources/hudson/model/Run/confirmDelete.jelly
            src/test/java/hudson/matrix/MatrixProjectTest.java
            http://jenkins-ci.org/commit/matrix-project-plugin/430a07af4b127c65afc296780ab000ada1171c9b
            Log:
            Merge pull request #39 from jcechace/JENKINS-26281

            JENKINS-26281 Matrix builds can be deleted

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oliver Gondža Path: src/main/java/hudson/matrix/MatrixBuild.java src/main/java/hudson/matrix/MatrixRun.java src/main/resources/hudson/matrix/Messages.properties src/main/resources/hudson/matrix/Messages_da.properties src/main/resources/hudson/matrix/Messages_de.properties src/main/resources/hudson/matrix/Messages_es.properties src/main/resources/hudson/matrix/Messages_ja.properties src/main/resources/hudson/matrix/Messages_nl.properties src/main/resources/hudson/matrix/Messages_pt.properties src/main/resources/hudson/matrix/Messages_pt_BR.properties src/main/resources/hudson/matrix/Messages_tr.properties src/main/resources/hudson/matrix/Messages_zh_CN.properties src/main/resources/hudson/matrix/Messages_zh_TW.properties src/main/resources/hudson/model/Run/confirmDelete.jelly src/test/java/hudson/matrix/MatrixProjectTest.java http://jenkins-ci.org/commit/matrix-project-plugin/430a07af4b127c65afc296780ab000ada1171c9b Log: Merge pull request #39 from jcechace/ JENKINS-26281 JENKINS-26281 Matrix builds can be deleted

              People

              • Assignee:
                olivergondza Oliver Gondža
                Reporter:
                olivergondza Oliver Gondža
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: