Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26331

WarExploder assumes build system uses target directory

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      WarExploder assumes that the build system uses a target directory for build artifacts. This causes problems when using Gradle and the gradle-jpi-plugin since Gradle uses a build directory for build artifacts. See WarExploder.java#L91.

      When using core versions >1.544 and <1.592, builds will fail when the target directory does exist. This has been introduced in bc4c1326 and fixed in 9aaeb0a3.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            changelog.html
            test/src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins/75eeccf8668e49396477d19fae365cb23442d40a
            Log:
            [FIXED JENKINS-26331] Noting merge of #1519.

            Compare: https://github.com/jenkinsci/jenkins/compare/28984e5920c6...75eeccf8668e

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: changelog.html test/src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins/75eeccf8668e49396477d19fae365cb23442d40a Log: [FIXED JENKINS-26331] Noting merge of #1519. Compare: https://github.com/jenkinsci/jenkins/compare/28984e5920c6...75eeccf8668e
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3922
            JENKINS-26331 use buildDirectory system property to configure target directory (Revision 1fae8c072a1e8da360cd10dca8b82d1cd1b00968)

            Result = SUCCESS
            daniel.spilker : 1fae8c072a1e8da360cd10dca8b82d1cd1b00968
            Files :

            • test/src/main/java/org/jvnet/hudson/test/WarExploder.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3922 JENKINS-26331 use buildDirectory system property to configure target directory (Revision 1fae8c072a1e8da360cd10dca8b82d1cd1b00968) Result = SUCCESS daniel.spilker : 1fae8c072a1e8da360cd10dca8b82d1cd1b00968 Files : test/src/main/java/org/jvnet/hudson/test/WarExploder.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            CHANGELOG.md
            src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiExtension.groovy
            src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy
            http://jenkins-ci.org/commit/gradle-jpi-plugin/69770cfc9ea76121faf951b879461e78c51933ef
            Log:
            set buildDirectory system property for Jenkins test harness, JENKINS-26331

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: CHANGELOG.md src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiExtension.groovy src/main/groovy/org/jenkinsci/gradle/plugins/jpi/JpiPlugin.groovy http://jenkins-ci.org/commit/gradle-jpi-plugin/69770cfc9ea76121faf951b879461e78c51933ef Log: set buildDirectory system property for Jenkins test harness, JENKINS-26331
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            job-dsl-plugin/build.gradle
            http://jenkins-ci.org/commit/job-dsl-plugin/724d3f31e6781e03b7989f6e48c08dca7119d313
            Log:
            updated Gradle JPI plugin to 0.8.1, removed workaround for JENKINS-26331

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: job-dsl-plugin/build.gradle http://jenkins-ci.org/commit/job-dsl-plugin/724d3f31e6781e03b7989f6e48c08dca7119d313 Log: updated Gradle JPI plugin to 0.8.1, removed workaround for JENKINS-26331
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Spilker
            Path:
            test/src/main/java/org/jvnet/hudson/test/WarExploder.java
            http://jenkins-ci.org/commit/jenkins-test-harness/9e3aa988ae25824817622df394af21b604e5f5ca
            Log:
            JENKINS-26331 use buildDirectory system property to configure target directory

            Originally-Committed-As: 1fae8c072a1e8da360cd10dca8b82d1cd1b00968

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Spilker Path: test/src/main/java/org/jvnet/hudson/test/WarExploder.java http://jenkins-ci.org/commit/jenkins-test-harness/9e3aa988ae25824817622df394af21b604e5f5ca Log: JENKINS-26331 use buildDirectory system property to configure target directory Originally-Committed-As: 1fae8c072a1e8da360cd10dca8b82d1cd1b00968

              People

              • Assignee:
                daspilker Daniel Spilker
                Reporter:
                daspilker Daniel Spilker
              • Votes:
                0 Vote for this issue
                Watchers:
                5 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: