Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26438

"Keep this build forever" button not visible if BuildDiscarder other than LogRotator is configured

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      Jenkins 1.565.1
    • Similar Issues:

      Description

      The button "Keep this build forever" is not visible in the build summary page when a BuildDiscarder other than LogRotator is configured. I don't think this is intentionally.

      The problem is in Jelly file core\src\main\resources\hudson\model\Run\logKeep.jelly, line 30:

      <j:if test="${it.parent.logRotator!=null and it.canToggleLogKeep()}">
      

      Should be fixed to:

      <j:if test="${it.parent.buildDiscarder!=null and it.canToggleLogKeep()}">
      

        Attachments

          Issue Links

            Activity

            Hide
            danielbeck Daniel Beck added a comment -

            I agree. Great analysis!

            Show
            danielbeck Daniel Beck added a comment - I agree. Great analysis!
            Hide
            jimilian Alexander A added a comment -

            Daniel Beck, could you fix it in next release, please? It's quite painful to use default LogRotator.

            Show
            jimilian Alexander A added a comment - Daniel Beck , could you fix it in next release, please? It's quite painful to use default LogRotator.
            Hide
            danielbeck Daniel Beck added a comment -

            Sorry about that delay. I'll try to get it done soon.

            Show
            danielbeck Daniel Beck added a comment - Sorry about that delay. I'll try to get it done soon.
            Hide
            danielbeck Daniel Beck added a comment -

            Again, sorry about the delay. In the future, this is something where you could definitely file a PR to get it fixed more quickly

            https://github.com/jenkinsci/jenkins/pull/2443

            Show
            danielbeck Daniel Beck added a comment - Again, sorry about the delay. In the future, this is something where you could definitely file a PR to get it fixed more quickly https://github.com/jenkinsci/jenkins/pull/2443
            Hide
            jimilian Alexander A added a comment -

            Daniel Beck, I didn't know that it's possible to create PR without signed CLA. Anyway, thanks a lot!

            Show
            jimilian Alexander A added a comment - Daniel Beck , I didn't know that it's possible to create PR without signed CLA. Anyway, thanks a lot!
            Hide
            danielbeck Daniel Beck added a comment -

            Merged towards 2.14.

            Show
            danielbeck Daniel Beck added a comment - Merged towards 2.14.

              People

              • Assignee:
                danielbeck Daniel Beck
                Reporter:
                matmoers Matthias Moers
              • Votes:
                1 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: