Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26698

Failure to recover from exception in Publisher.needsToRunAfterFinalized

    Details

    • Similar Issues:

      Description

      If Publisher.needsToRunAfterFinalized throws an exception, the workspace lease is not released.

      Worse, the exception is not even reported anywhere if there was already an exception in the publisher, because Run.handleFatalBuildProblem closed the build log the first time, so the stack trace is lost.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/Build.java
            core/src/main/java/hudson/model/Run.java
            test/src/test/java/hudson/model/BuildExecutionTest.java
            http://jenkins-ci.org/commit/jenkins/7e72e7d1218e3443650d8d0c1e20b70d558422b0
            Log:
            JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease.
            Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too.
            (cherry picked from commit 62af87b67a1097376b9af554421e621d32f7013f)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Build.java core/src/main/java/hudson/model/Run.java test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/7e72e7d1218e3443650d8d0c1e20b70d558422b0 Log: JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. Also stop closing the build log in Run.handleFatalBuildProblem; we want to see any subsequent messages too. (cherry picked from commit 62af87b67a1097376b9af554421e621d32f7013f)
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Jesse Glick
            Path:
            core/src/main/java/hudson/model/Build.java
            core/src/main/resources/hudson/model/Messages.properties
            test/src/test/java/hudson/model/BuildExecutionTest.java
            http://jenkins-ci.org/commit/jenkins/f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b
            Log:
            JENKINS-26698 Localization as suggested by @daniel-beck.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Jesse Glick Path: core/src/main/java/hudson/model/Build.java core/src/main/resources/hudson/model/Messages.properties test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b Log: JENKINS-26698 Localization as suggested by @daniel-beck.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/Build.java
            core/src/main/resources/hudson/model/Messages.properties
            test/src/test/java/hudson/model/BuildExecutionTest.java
            http://jenkins-ci.org/commit/jenkins/776380ff4efa46c5afa6850dbca810f333039a40
            Log:
            Merge pull request #1635 from jglick/l10n-JENKINS-26698

            JENKINS-26698 Localization follow-up

            Compare: https://github.com/jenkinsci/jenkins/compare/a976bdcf64a8...776380ff4efa

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/Build.java core/src/main/resources/hudson/model/Messages.properties test/src/test/java/hudson/model/BuildExecutionTest.java http://jenkins-ci.org/commit/jenkins/776380ff4efa46c5afa6850dbca810f333039a40 Log: Merge pull request #1635 from jglick/l10n- JENKINS-26698 JENKINS-26698 Localization follow-up Compare: https://github.com/jenkinsci/jenkins/compare/a976bdcf64a8...776380ff4efa
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4060
            JENKINS-26698 Localization as suggested by @daniel-beck. (Revision f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b)

            Result = SUCCESS
            jesse glick : f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b
            Files :

            • core/src/main/java/hudson/model/Build.java
            • core/src/main/resources/hudson/model/Messages.properties
            • test/src/test/java/hudson/model/BuildExecutionTest.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4060 JENKINS-26698 Localization as suggested by @daniel-beck. (Revision f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b) Result = SUCCESS jesse glick : f0d9e13ec85ced63ba9db570f4a5c02bc83bbf3b Files : core/src/main/java/hudson/model/Build.java core/src/main/resources/hudson/model/Messages.properties test/src/test/java/hudson/model/BuildExecutionTest.java
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4292
            JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 7e72e7d1218e3443650d8d0c1e20b70d558422b0)

            Result = UNSTABLE
            ogondza : 7e72e7d1218e3443650d8d0c1e20b70d558422b0
            Files :

            • core/src/main/java/hudson/model/Build.java
            • test/src/test/java/hudson/model/BuildExecutionTest.java
            • core/src/main/java/hudson/model/Run.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 JENKINS-26698 Make sure BuildExecution.cleanUp always calls super, to release the workspace lease. (Revision 7e72e7d1218e3443650d8d0c1e20b70d558422b0) Result = UNSTABLE ogondza : 7e72e7d1218e3443650d8d0c1e20b70d558422b0 Files : core/src/main/java/hudson/model/Build.java test/src/test/java/hudson/model/BuildExecutionTest.java core/src/main/java/hudson/model/Run.java

              People

              • Assignee:
                jglick Jesse Glick
                Reporter:
                jglick Jesse Glick
              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: