Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26705

Support flat style badges

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      The gold standard of embeddable badges is shields.io. They currently support three styles of badges:

      Some services like travis-ci.org have already switched to the flat style.

      Mixing badges of different styles results in ugliness.

      It would be nice if embeddable-build-status-plugin would allow the user to specify the desired style using ?style=flat or ?style=plastic.

      It would also be nice to switch to the flat style as the new default on Feb 1 2015.

        Attachments

          Activity

          Show
          mgedmin Marius Gedminas added a comment - Pull request at https://github.com/jenkinsci/embeddable-build-status-plugin/pull/12
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Marius Gedminas
          Path:
          src/main/java/org/jenkinsci/plugins/badge/BadgeAction.java
          src/main/java/org/jenkinsci/plugins/badge/BadgeActionFactory.java
          src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java
          src/main/java/org/jenkinsci/plugins/badge/PublicBadgeAction.java
          src/main/java/org/jenkinsci/plugins/badge/RunBadgeAction.java
          src/main/java/org/jenkinsci/plugins/badge/RunBadgeActionFactory.java
          src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.groovy
          src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.properties
          src/main/resources/org/jenkinsci/plugins/badge/RunBadgeAction/index.groovy
          src/main/resources/org/jenkinsci/plugins/badge/RunBadgeAction/index.properties
          src/main/webapp/status/build-failing-red-flat.svg
          src/main/webapp/status/build-passing-brightgreen-flat.svg
          src/main/webapp/status/build-running-blue-flat.svg
          src/main/webapp/status/build-unknown-lightgrey-flat.svg
          src/main/webapp/status/build-unstable-yellow-flat.svg
          src/test/java/org/jenkinsci/plugins/badge/PublicBadgeActionTest.java
          http://jenkins-ci.org/commit/embeddable-build-status-plugin/f13eccb8551fd3c888f3f44856b539c344d0da62
          Log:
          Add flat-styled images, make them default

          You can get the old "plastic" style badges by adding ?style=plastic to
          the badge URL.

          The new images were generated with

          wget https://img.shields.io/badge/build-failing-red.svg?style=flat -O build-failing-red-flat.svg
          wget https://img.shields.io/badge/build-passing-brightgreen.svg?style=flat -O build-passing-brightgreen-flat.svg
          wget https://img.shields.io/badge/build-running-blue.svg?style=flat -O build-running-blue-flat.svg
          wget https://img.shields.io/badge/build-unknown-lightgrey.svg?style=flat -O build-unknown-lightgrey-flat.svg
          wget https://img.shields.io/badge/build-unstable-yellow.svg?style=flat -O build-unstable-yellow-flat.svg

          Fixes JENKINS-26705.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Marius Gedminas Path: src/main/java/org/jenkinsci/plugins/badge/BadgeAction.java src/main/java/org/jenkinsci/plugins/badge/BadgeActionFactory.java src/main/java/org/jenkinsci/plugins/badge/ImageResolver.java src/main/java/org/jenkinsci/plugins/badge/PublicBadgeAction.java src/main/java/org/jenkinsci/plugins/badge/RunBadgeAction.java src/main/java/org/jenkinsci/plugins/badge/RunBadgeActionFactory.java src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.groovy src/main/resources/org/jenkinsci/plugins/badge/BadgeAction/index.properties src/main/resources/org/jenkinsci/plugins/badge/RunBadgeAction/index.groovy src/main/resources/org/jenkinsci/plugins/badge/RunBadgeAction/index.properties src/main/webapp/status/build-failing-red-flat.svg src/main/webapp/status/build-passing-brightgreen-flat.svg src/main/webapp/status/build-running-blue-flat.svg src/main/webapp/status/build-unknown-lightgrey-flat.svg src/main/webapp/status/build-unstable-yellow-flat.svg src/test/java/org/jenkinsci/plugins/badge/PublicBadgeActionTest.java http://jenkins-ci.org/commit/embeddable-build-status-plugin/f13eccb8551fd3c888f3f44856b539c344d0da62 Log: Add flat-styled images, make them default You can get the old "plastic" style badges by adding ?style=plastic to the badge URL. The new images were generated with wget https://img.shields.io/badge/build-failing-red.svg?style=flat -O build-failing-red-flat.svg wget https://img.shields.io/badge/build-passing-brightgreen.svg?style=flat -O build-passing-brightgreen-flat.svg wget https://img.shields.io/badge/build-running-blue.svg?style=flat -O build-running-blue-flat.svg wget https://img.shields.io/badge/build-unknown-lightgrey.svg?style=flat -O build-unknown-lightgrey-flat.svg wget https://img.shields.io/badge/build-unstable-yellow.svg?style=flat -O build-unstable-yellow-flat.svg Fixes JENKINS-26705 .
          Hide
          ssbarnea Sorin Sbarnea added a comment -

          Fixed in current release, flat ones are default.

          Show
          ssbarnea Sorin Sbarnea added a comment - Fixed in current release, flat ones are default.

            People

            • Assignee:
              mgedmin Marius Gedminas
              Reporter:
              mgedmin Marius Gedminas
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: