Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-26718

Can't discard promoted-builds Promotions

    Details

    • Similar Issues:

      Description

      If all OldDataMonitor entries are related to Promoted Builds, then the monitor isActivated(), but it won't be able to discard these builds.

      The problem is that hudson.diagnosis.OldDataMonitor.RunSaveableReference expects runs to be locatable by their externalizableId, but Promotions are broken in this respect.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ryan Campbell
            Path:
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            http://jenkins-ci.org/commit/jenkins/327f7780133b2e6083f49686e43298af83b0dea6
            Log:
            JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: core/src/main/java/hudson/diagnosis/OldDataMonitor.java test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java http://jenkins-ci.org/commit/jenkins/327f7780133b2e6083f49686e43298af83b0dea6 Log: JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ryan Campbell
            Path:
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            http://jenkins-ci.org/commit/jenkins/d6d96e14c11f0ea38ad18c3357012357eb07588d
            Log:
            Merge pull request #1557 from recampbell/JENKINS-26718

            JENKINS-26718 OldDataMonitor: Handle poorly written project types

            Compare: https://github.com/jenkinsci/jenkins/compare/144a6da24af2...d6d96e14c11f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: core/src/main/java/hudson/diagnosis/OldDataMonitor.java test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java http://jenkins-ci.org/commit/jenkins/d6d96e14c11f0ea38ad18c3357012357eb07588d Log: Merge pull request #1557 from recampbell/ JENKINS-26718 JENKINS-26718 OldDataMonitor: Handle poorly written project types Compare: https://github.com/jenkinsci/jenkins/compare/144a6da24af2...d6d96e14c11f
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #3962
            JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname (Revision 327f7780133b2e6083f49686e43298af83b0dea6)

            Result = SUCCESS
            ryan campbell : 327f7780133b2e6083f49686e43298af83b0dea6
            Files :

            • test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            • core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #3962 JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname (Revision 327f7780133b2e6083f49686e43298af83b0dea6) Result = SUCCESS ryan campbell : 327f7780133b2e6083f49686e43298af83b0dea6 Files : test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ryan Campbell
            Path:
            changelog.html
            http://jenkins-ci.org/commit/jenkins/a944634e4f2f97d58fe2736dcfcd9fd95df686a1
            Log:
            Merge pull request #1561 from recampbell/JENKINS-26718

            [FIXED JENKINS-26718] Update changelog

            Compare: https://github.com/jenkinsci/jenkins/compare/fac3c21367d1...a944634e4f2f

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: changelog.html http://jenkins-ci.org/commit/jenkins/a944634e4f2f97d58fe2736dcfcd9fd95df686a1 Log: Merge pull request #1561 from recampbell/ JENKINS-26718 [FIXED JENKINS-26718] Update changelog Compare: https://github.com/jenkinsci/jenkins/compare/fac3c21367d1...a944634e4f2f
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Ryan Campbell
            Path:
            core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            http://jenkins-ci.org/commit/jenkins/5ed111f0bc4aa1b2608b2aa780bc8778ef6ae60a
            Log:
            JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname

            (cherry picked from commit 327f7780133b2e6083f49686e43298af83b0dea6)

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Ryan Campbell Path: core/src/main/java/hudson/diagnosis/OldDataMonitor.java test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java http://jenkins-ci.org/commit/jenkins/5ed111f0bc4aa1b2608b2aa780bc8778ef6ae60a Log: JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname (cherry picked from commit 327f7780133b2e6083f49686e43298af83b0dea6)
            Hide
            dogfood dogfood added a comment -

            Integrated in jenkins_main_trunk #4292
            JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname (Revision 5ed111f0bc4aa1b2608b2aa780bc8778ef6ae60a)

            Result = UNSTABLE
            ogondza : 5ed111f0bc4aa1b2608b2aa780bc8778ef6ae60a
            Files :

            • core/src/main/java/hudson/diagnosis/OldDataMonitor.java
            • test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java
            Show
            dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 JENKINS-26718 Allow runs to be discarded even if their project can't be found by its fullname (Revision 5ed111f0bc4aa1b2608b2aa780bc8778ef6ae60a) Result = UNSTABLE ogondza : 5ed111f0bc4aa1b2608b2aa780bc8778ef6ae60a Files : core/src/main/java/hudson/diagnosis/OldDataMonitor.java test/src/test/java/hudson/diagnosis/OldDataMonitorTest.java

              People

              • Assignee:
                recampbell Ryan Campbell
                Reporter:
                recampbell Ryan Campbell
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: