Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27375

Add options to enable / disable choice providers

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      There're cases some choice providers security problems: JENKINS-26721, JENKINS-27374
      Though those problems should be fixed in wach choice providers, it can be complicated and take much time to make a new release.

      Providing system global options to enable / disable choice providers allow administrators workarounds to avoid those problems.

        Attachments

          Issue Links

            Activity

            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/f7e23a37c9b6c79731d34ebc27cbe45d47fc5b23
            Log:
            [FIXED JENKINS-27375] Enables to disable specific choice list providers in system configuration page.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/f7e23a37c9b6c79731d34ebc27cbe45d47fc5b23 Log: [FIXED JENKINS-27375] Enables to disable specific choice list providers in system configuration page.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/5b1ff211792f32fb59c21b58c3d3b00a09e13c52
            Log:
            JENKINS-27375 the nested configuration in enabled / disabled section is enabled only when inheriting ChoiceListProviderDescriptor.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/5b1ff211792f32fb59c21b58c3d3b00a09e13c52 Log: JENKINS-27375 the nested configuration in enabled / disabled section is enabled only when inheriting ChoiceListProviderDescriptor.
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java
            src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java
            src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly
            src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/74176e38f536a58ce32d03552885ccb7e434d43c
            Log:
            Merge pull request #12 from ikedam/feature/JENKINS-27375_DisableProviders

            JENKINS-27375 Add options to enable / disable choice providers

            Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/8c3df4246c76...74176e38f536

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ChoiceListProviderDescriptor.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition.java src/main/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider.java src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/config.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/FilenameChoiceListProvider/help.html src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/GlobalTextareaChoiceListProvider/global.jelly src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionSimpleTest.java src/test/java/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterJenkinsRule.java src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/config.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/EnableConfigurableMockChoiceListProvider/global.jelly src/test/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinitionJenkinsTest/MockChoiceListProvider/config.jelly http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/74176e38f536a58ce32d03552885ccb7e434d43c Log: Merge pull request #12 from ikedam/feature/ JENKINS-27375 _DisableProviders JENKINS-27375 Add options to enable / disable choice providers Compare: https://github.com/jenkinsci/extensible-choice-parameter-plugin/compare/8c3df4246c76...74176e38f536
            Hide
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: ikedam
            Path:
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly
            src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global_ja.properties
            http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c6c822e1a715a57a911129702d8994913d2d0822
            Log:
            JENKINS-27375 More descriptions for the system configuration page.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: ikedam Path: src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global.jelly src/main/resources/jp/ikedam/jenkins/plugins/extensible_choice_parameter/ExtensibleChoiceParameterDefinition/global_ja.properties http://jenkins-ci.org/commit/extensible-choice-parameter-plugin/c6c822e1a715a57a911129702d8994913d2d0822 Log: JENKINS-27375 More descriptions for the system configuration page.
            Hide
            ikedam ikedam added a comment -

            Fixed in 1.3.0.
            It will be available in a day.

            Show
            ikedam ikedam added a comment - Fixed in 1.3.0. It will be available in a day.

              People

              • Assignee:
                ikedam ikedam
                Reporter:
                ikedam ikedam
              • Votes:
                0 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: