Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-27641

Name of version selection build parameter should be customized

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Currently, the name of the version selection build parameter is auto-generated with the pattern groupid.artifactid. This is fine if this token is only used in the build step Artifact Resolver. In an Execute Shell build step, this token is unusable because shell variable must not have dots in its name. Therefore, it would be useful when the name of the version selection build parameter is customizable, so that a shell conformed name can be chose.

        Attachments

          Activity

          Hide
          mirumpf Michael Rumpf added a comment - - edited

          As long as this is not fully configurable there is work-around where the name of the "repository" (from global config) is set to the selected version string. See the Maven POM example on how we work-around this issue.

          Show
          mirumpf Michael Rumpf added a comment - - edited As long as this is not fully configurable there is work-around where the name of the "repository" (from global config) is set to the selected version string. See the Maven POM example on how we work-around this issue.
          Hide
          mirumpf Michael Rumpf added a comment -

          Fixed by adding a new field "Property Name" to the config page. When the property is used, the name entered into the field is used as property name. If not, the original behavior is used, adding the version property with the name of the repository to the job execution.

          Show
          mirumpf Michael Rumpf added a comment - Fixed by adding a new field "Property Name" to the config page. When the property is used, the name entered into the field is used as property name. If not, the original behavior is used, adding the version property with the name of the repository to the job execution.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: mrumpf
          Path:
          src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition.java
          src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterValue.java
          src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.jelly
          src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.properties
          src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config_de.properties
          http://jenkins-ci.org/commit/repository-connector-plugin/8b485b775caa72f15bd4e455ddf68e23bb413a32
          Log:
          JENKINS-27641: Made the parameter name configurable. When the propertyName field is left empty, the default property groupId.artifactId=value is set. If the propertyName is set then the parameter propertyName=value will be passed to the build.

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: mrumpf Path: src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition.java src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterValue.java src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.jelly src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.properties src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config_de.properties http://jenkins-ci.org/commit/repository-connector-plugin/8b485b775caa72f15bd4e455ddf68e23bb413a32 Log: JENKINS-27641 : Made the parameter name configurable. When the propertyName field is left empty, the default property groupId.artifactId=value is set. If the propertyName is set then the parameter propertyName=value will be passed to the build.
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Michael Rumpf
          Path:
          src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition.java
          src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterValue.java
          src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.jelly
          src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.properties
          src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config_de.properties
          http://jenkins-ci.org/commit/repository-connector-plugin/9d9175fb8de509d94733f28c51f63205a4d9e7f7
          Log:
          Merge pull request #9 from mrumpf/master

          Fixes for JENKINS-28323 and JENKINS-27641. All tests are fine.

          Compare: https://github.com/jenkinsci/repository-connector-plugin/compare/a75b5e676155...9d9175fb8de5

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Michael Rumpf Path: src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition.java src/main/java/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterValue.java src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.jelly src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config.properties src/main/resources/org/jvnet/hudson/plugins/repositoryconnector/VersionParameterDefinition/config_de.properties http://jenkins-ci.org/commit/repository-connector-plugin/9d9175fb8de509d94733f28c51f63205a4d9e7f7 Log: Merge pull request #9 from mrumpf/master Fixes for JENKINS-28323 and JENKINS-27641 . All tests are fine. Compare: https://github.com/jenkinsci/repository-connector-plugin/compare/a75b5e676155...9d9175fb8de5

            People

            • Assignee:
              mirumpf Michael Rumpf
              Reporter:
              sparsick Sandra Parsick
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: