Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28115

Division by zero in Executor.getProgress

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Stack traces like

      WARNING: Caught exception evaluating: executor.progress in /ajaxExecutors. Reason: java.lang.reflect.InvocationTargetException
      java.lang.reflect.InvocationTargetException
      ...
      	at java.lang.Thread.run(Thread.java:744)
      Caused by: java.lang.ArithmeticException: / by zero
      	at hudson.model.Executor.getProgress(Executor.java:649)
      	... 154 more
      

        Attachments

          Activity

          Hide
          jglick Jesse Glick added a comment -

          Marking an LTS candidate under the assumption that this is fixing a regression introduced in 1.607 by the fix of JENKINS-27565, though that is not clear to me.

          Show
          jglick Jesse Glick added a comment - Marking an LTS candidate under the assumption that this is fixing a regression introduced in 1.607 by the fix of JENKINS-27565 , though that is not clear to me.
          Hide
          stephenconnolly Stephen Connolly added a comment -

          It does not fix a regression introduced in 1.607, rather I spotted the stack trace while testing (I cannot recall whether on pre 1.607 or post 1.607 testing) and analysis revealed the potential of a div by zero, so might as well fix.

          No harm in backporting to LTS anyway

          Show
          stephenconnolly Stephen Connolly added a comment - It does not fix a regression introduced in 1.607, rather I spotted the stack trace while testing (I cannot recall whether on pre 1.607 or post 1.607 testing) and analysis revealed the potential of a div by zero, so might as well fix. No harm in backporting to LTS anyway
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          core/src/main/java/hudson/model/Executor.java
          http://jenkins-ci.org/commit/jenkins/e7efb4430308acad09ceae9ee3f9433a22692ce4
          Log:
          [FIXED JENKINS-28115] Division by zero in Executor.getProgress()

          ```
          WARNING: Caught exception evaluating: executor.progress in /ajaxExecutors. Reason: java.lang.reflect.InvocationTargetException
          java.lang.reflect.InvocationTargetException
          ...
          at java.lang.Thread.run(Thread.java:744)
          Caused by: java.lang.ArithmeticException: / by zero
          at hudson.model.Executor.getProgress(Executor.java:649)
          ... 154 more
          ```
          (cherry picked from commit e685b604eeeed9c48bee2f728c3ecec3303e5c56)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: core/src/main/java/hudson/model/Executor.java http://jenkins-ci.org/commit/jenkins/e7efb4430308acad09ceae9ee3f9433a22692ce4 Log: [FIXED JENKINS-28115] Division by zero in Executor.getProgress() ``` WARNING: Caught exception evaluating: executor.progress in /ajaxExecutors. Reason: java.lang.reflect.InvocationTargetException java.lang.reflect.InvocationTargetException ... at java.lang.Thread.run(Thread.java:744) Caused by: java.lang.ArithmeticException: / by zero at hudson.model.Executor.getProgress(Executor.java:649) ... 154 more ``` (cherry picked from commit e685b604eeeed9c48bee2f728c3ecec3303e5c56)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: tfennelly
          Path:
          changelog.html
          cli/pom.xml
          core/pom.xml
          core/src/main/java/hudson/model/Executor.java
          core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly
          ips/jenkins.xml
          ips/proto.py
          ips/readme.txt
          plugins/pom.xml
          pom.xml
          test/pom.xml
          war/pom.xml
          http://jenkins-ci.org/commit/jenkins/30ece5ffb20d354173cec3b6d7a2ea902a9eb681
          Log:
          Merge branch 'master' into extensionlist-listener

          • master:
            Noting merge of JENKINS-28111
            @jglick wants it this way
            Noting merge of JENKINS-28115
            [FIXED JENKINS-28115] Division by zero in Executor.getProgress()
            [FIXED JENKINS-28111] JNLP slave JVM Options are inconsistently applied
            updated changelog for release
            [maven-release-plugin] prepare for next development iteration
            [maven-release-plugin] prepare release jenkins-1.611
            remove ips profile
            Now that packaging is in https://github.com/jenkinsci/packaging and given that the ips packaging is stale, we should just drop this
          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: tfennelly Path: changelog.html cli/pom.xml core/pom.xml core/src/main/java/hudson/model/Executor.java core/src/main/resources/hudson/slaves/JNLPLauncher/main.jelly ips/jenkins.xml ips/proto.py ips/readme.txt plugins/pom.xml pom.xml test/pom.xml war/pom.xml http://jenkins-ci.org/commit/jenkins/30ece5ffb20d354173cec3b6d7a2ea902a9eb681 Log: Merge branch 'master' into extensionlist-listener master: Noting merge of JENKINS-28111 @jglick wants it this way Noting merge of JENKINS-28115 [FIXED JENKINS-28115] Division by zero in Executor.getProgress() [FIXED JENKINS-28111] JNLP slave JVM Options are inconsistently applied updated changelog for release [maven-release-plugin] prepare for next development iteration [maven-release-plugin] prepare release jenkins-1.611 remove ips profile Now that packaging is in https://github.com/jenkinsci/packaging and given that the ips packaging is stale, we should just drop this
          Hide
          dogfood dogfood added a comment -

          Integrated in jenkins_main_trunk #4292
          [FIXED JENKINS-28115] Division by zero in Executor.getProgress() (Revision e7efb4430308acad09ceae9ee3f9433a22692ce4)

          Result = UNSTABLE
          ogondza : e7efb4430308acad09ceae9ee3f9433a22692ce4
          Files :

          • core/src/main/java/hudson/model/Executor.java
          Show
          dogfood dogfood added a comment - Integrated in jenkins_main_trunk #4292 [FIXED JENKINS-28115] Division by zero in Executor.getProgress() (Revision e7efb4430308acad09ceae9ee3f9433a22692ce4) Result = UNSTABLE ogondza : e7efb4430308acad09ceae9ee3f9433a22692ce4 Files : core/src/main/java/hudson/model/Executor.java

            People

            • Assignee:
              stephenconnolly Stephen Connolly
              Reporter:
              stephenconnolly Stephen Connolly
            • Votes:
              1 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: