Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-28245

ChannelPinger timeout should be configurable

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Resolved (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: core
    • Labels:
      None
    • Similar Issues:

      Description

      It currently allows the interval to be configured, but the timeout is fixed at four minutes.

      PR incoming.

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: David Hoover
          Path:
          core/pom.xml
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/test/java/hudson/slaves/ChannelPingerTest.java
          pom.xml
          http://jenkins-ci.org/commit/jenkins/d563062747618ae68644c8984ed43f6447c5e685
          Log:
          [FIXED JENKINS-28245] Allow finer-grained tuning of ChannelPinger.

          • Allows customization in seconds, not minutes
          • Allows customization of the ping timeout (before, you could set a
            custom interval, but the timeout would always be PingThread's 4
            minute default)

          This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing;
          without one provided, the JVM will generate one on demand which is
          sufficient for the purposes here since these are never persisted and
          master & slave run the same compiled code. (And it demonstrably works
          since countless other MasterToSlaveCallables fail to specify their own
          custom IDs)

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: David Hoover Path: core/pom.xml core/src/main/java/hudson/slaves/ChannelPinger.java core/src/test/java/hudson/slaves/ChannelPingerTest.java pom.xml http://jenkins-ci.org/commit/jenkins/d563062747618ae68644c8984ed43f6447c5e685 Log: [FIXED JENKINS-28245] Allow finer-grained tuning of ChannelPinger. Allows customization in seconds, not minutes Allows customization of the ping timeout (before, you could set a custom interval, but the timeout would always be PingThread's 4 minute default) This also drops the serialVersionUID from ChannelPinger.SetUpRemotePing; without one provided, the JVM will generate one on demand which is sufficient for the purposes here since these are never persisted and master & slave run the same compiled code. (And it demonstrably works since countless other MasterToSlaveCallables fail to specify their own custom IDs)
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Alvaro Lobato
          Path:
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/test/java/hudson/slaves/ChannelPingerTest.java
          http://jenkins-ci.org/commit/jenkins/6dea3c3f70968d18482e2f650be8fd597b4d1ce1
          Log:
          JENKINS-28245 - Finish deadmoose's work to allow defining agent ping interval and ping timeout in seconds

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alvaro Lobato Path: core/src/main/java/hudson/slaves/ChannelPinger.java core/src/test/java/hudson/slaves/ChannelPingerTest.java http://jenkins-ci.org/commit/jenkins/6dea3c3f70968d18482e2f650be8fd597b4d1ce1 Log: JENKINS-28245 - Finish deadmoose's work to allow defining agent ping interval and ping timeout in seconds
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          core/pom.xml
          core/src/main/java/hudson/slaves/ChannelPinger.java
          core/src/test/java/hudson/slaves/ChannelPingerTest.java
          pom.xml
          http://jenkins-ci.org/commit/jenkins/1868c8486bdb7a39a7beec0787bb40e15b80de48
          Log:
          Merge pull request #2645 from alvarolobato/JENKINS-28245

          [FIX JENKINS-28245] - Allow defining agent ping interval and ping timeout in seconds

          Compare: https://github.com/jenkinsci/jenkins/compare/e7e51eeb62f1...1868c8486bdb

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/pom.xml core/src/main/java/hudson/slaves/ChannelPinger.java core/src/test/java/hudson/slaves/ChannelPingerTest.java pom.xml http://jenkins-ci.org/commit/jenkins/1868c8486bdb7a39a7beec0787bb40e15b80de48 Log: Merge pull request #2645 from alvarolobato/ JENKINS-28245 [FIX JENKINS-28245] - Allow defining agent ping interval and ping timeout in seconds Compare: https://github.com/jenkinsci/jenkins/compare/e7e51eeb62f1...1868c8486bdb
          Hide
          oleg_nenashev Oleg Nenashev added a comment - - edited

          Released in jenkins-2.37
          Thanks to Alvaro Lobato for finishing the PR

          Show
          oleg_nenashev Oleg Nenashev added a comment - - edited Released in jenkins-2.37 Thanks to Alvaro Lobato for finishing the PR
          Hide
          marko_andrijevic Marko Andrijevic added a comment -

          Instructions on how these settings can be applied can be found here. Relevant settings are:

          • hudson.slaves.ChannelPinger.pingIntervalSeconds
          • hudson.slaves.ChannelPinger.pingTimeoutSeconds
          Show
          marko_andrijevic Marko Andrijevic added a comment - Instructions on how these settings can be applied can be found here . Relevant settings are: hudson.slaves.ChannelPinger.pingIntervalSeconds hudson.slaves.ChannelPinger.pingTimeoutSeconds

            People

            • Assignee:
              deadmoose David Hoover
              Reporter:
              deadmoose David Hoover
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: